Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Dimension Command doesn't work as expected #20563

Closed
mickaelandrieu opened this issue Apr 5, 2023 · 4 comments
Closed

Add Custom Dimension Command doesn't work as expected #20563

mickaelandrieu opened this issue Apr 5, 2023 · 4 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@mickaelandrieu
Copy link

mickaelandrieu commented Apr 5, 2023

Context

I want to add custom dimensions using the Console

Expected Behavior

It should work as documented.

Current Behavior

It does not, probably because the condition on message confirmation doesn't work as expected

NOK

And the program stay this way for hours (waiting for a confirmation message not displayed IMHO ? IDK)

Possible Solution

This suggestion is backed up by the fact it's still possible to add custom dimensions without interacting with the console:

OK

Steps to Reproduce (for Bugs)

  1. docker-compose exec app /usr/local/bin/php /var/www/html/console customdimensions:add-custom-dimension --scope=action --count=1
  2. docker-compose exec app /usr/local/bin/php /var/www/html/console customdimensions:add-custom-dimension --scope=action --count=1 --no-interaction

Your Environment

  • Matomo Version: the most recent 4.X
  • PHP Version: 8.1
  • Server Operating System: Ubuntu server
  • Additionally installed plugins: I'm not allowed to list them
  • Browser: Irrelevant
  • Operating System: Irrelevant
@mickaelandrieu mickaelandrieu added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Apr 5, 2023
@sgiehl
Copy link
Member

sgiehl commented Apr 5, 2023

Hi @mickaelandrieu. Thanks for taking the time to report this issue.
I've tried reproducing it, but for me it actually worked without problems. Did you try typing an y and pressing enter? There should actually be a confirmation question displayed, but seems that doesn't work for you for any reason:

image

Anyway, there had been some changes around commands due to updating the symfony console dependency in our upcoming major release. So I assume this will be fixed with Matomo 5. If you still see this problem after Matomo 5 was released, feel free to create another report.

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
@mickaelandrieu
Copy link
Author

mickaelandrieu commented Apr 5, 2023

Please tag it as "wont fix", so people won't add issues on 4.X again :)

Did you try typing an y and pressing enter?

Yes, it doesn't execute the creation of custom dimensions.

So I assume this will be fixed with Matomo 5.

Yes, probably. I'll upgrade Matomo by July or August, I'll let you know atm.

@sgiehl sgiehl added wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Apr 5, 2023
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/unable-to-increase-custom-dimension-count/54323/2

@atom-box
Copy link
Contributor

For one user, the
customdimensions:add-custom-dimension
command blew up their server. Their message follows:

Today I attempted to run script to add to the max action custom dimensions. This was the command I ran from
./console customdimensions:add-custom-dimension --scope=action --count=5

Since initiating, our matomo site has been returning a 503 Service Unavailable message. I see the following in the apache error_log:

server reached MaxRequestWorkers setting, consider raising the MaxRequestWorkers setting

server is within MinSpareThreads of MaxRequestWorkers, consider raising the MaxRequestWorkers setting

What solved it

I updated mpm_event_module apache config to get past the maxrequestworker limitation and allowed us to get to the point where it exposed a MySQL error of too many connections. Our DBAs killed the connection and we are back in business.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

4 participants