Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Twitter to X across the platform #21171

Open
Stan-vw opened this issue Aug 24, 2023 · 2 comments
Open

Rename Twitter to X across the platform #21171

Stan-vw opened this issue Aug 24, 2023 · 2 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@Stan-vw
Copy link
Contributor

Stan-vw commented Aug 24, 2023

Context

As Twitter has rebranded to X, we should adjust our references to it.
I'm not sure about all places where we refer to it, it might not be obvious if we use the word "tweet" anywhere.

Expected Behavior

We should refer to the up to date brand of the platforms we refer to.

Current Behavior

Referring to old brandname

@Stan-vw Stan-vw added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Aug 24, 2023
@michalkleiner michalkleiner added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Aug 24, 2023
@michalkleiner michalkleiner added this to the For Prioritization milestone Aug 24, 2023
@michalkleiner
Copy link
Contributor

Not sure about all the places we refer to former Twitter but I can imagine that it could become confusing if we just replace it with X. People unfamiliar with either could see that as a mistake, so we could use use 'X (formerly Twitter)' or similar. With tweets, I would still use the word tweet, it's not even in a dictionary, so the meaning is set.
I'd say we can leave this up to the new technical writer to suggest what it needs to change to.

@sgiehl
Copy link
Member

sgiehl commented Aug 24, 2023

Twitter is detected as social network here: https://github.com/matomo-org/searchengine-and-social-list/blob/master/Socials.yml#L243-L245
We could change the name there, which would cause it to be detected with the new name after the list was updated on an instance.
But this would cause possible data accuracy problems for the customer:

  • Old data would still have been tracked with the name Twitter, but new visitors would be tracked with X. So segmenting for it would require to segment for both, the old and new name as or condition.
  • Referrer reports by default would have a similar problem. So without further changes X and Twitter would appear in reports, when viewing a report that contains old and new data. We could implement a workaround for those reports, so the API combines the old and new records if any before returning data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants