[Bug] Failing "Matomo Test / UI (1)" - Date format must be: YYYY-MM-DD - given: compareDates%5B%5D=2011-31-12

[rr-it]

What happened?

New PR #20718 but "Matomo Test / UI (1)" failed in Github CI:

Failing query:
date=2012-01-01&module=API&format=json&method=API.getProcessedReport&apiModule=VisitsSummary&apiAction=get&compare=1&comparePeriods%5B%5D=day&compareDates%5B%5D=2011-31-12&format_metrics=1&segment=&idSite=1&period=day

What should happen?

Date format must be: YYYY-MM-DD
So compareDates%5B%5D=2011-31-12 is invalid and instead must be compareDates%5B%5D=2011-12-31

How can this be reproduced?

Run "Matomo Test / UI (1)"

Matomo version

5.x-dev

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

2024-01-03T15:35:15.6983443Z ERROR API[2024-01-03 15:26:46 UTC] [4339c] Uncaught exception in API: /home/runner/work/matomo/matomo/matomo/core/Date.php(1142): Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information): false [Query: ?date=2012-01-01&module=API&format=json&method=API.getProcessedReport&apiModule=VisitsSummary&apiAction=get&compare=1&comparePeriods%5B%5D=day&compareDates%5B%5D=2011-31-12&format_metrics=1&segment=&idSite=1&period=day, CLI mode: 0]

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[sgiehl]

Hi @rr-it
I'm not sure which failing test your are referring to. At least I can't see one in that test suite.
Anyway. I search the code base and seems the invalid date is provided here:
https://github.com/matomo-org/matomo/blob/5.x-dev/tests/UI/specs/PeriodSelector_spec.js#L143
Not sure if this is done on purpose or was added by mistake.

[rr-it]

I found the ERROR API log-entry in the "raw logs":

---

This new test was introduced with #21242
And "Matomo Test / UI (1)" was also failing on this PR - but logs are no longer available.

https://github.com/matomo-org/matomo/blob/85948b63b2a2866b18a47e7d3628fe74cb0ecd46/tests/UI/specs/PeriodSelector_spec.js#L142C1-L147

        it('should select "previous period" from URL', async function () {
          await page.goto(url + '&comparePeriods[]=day&comparePeriodType=previousPeriod&compareDates[]=2011-31-12');
          await page.waitForNetworkIdle();

          expect(await getSelectedPeriodType()).to.match(/Period/);
        });

@caddoo May we change this test to compareDates[]=2011-12-31 instead of the current compareDates[]=2011-31-12?

[sgiehl]

@rr-it The test itself is passing. And the log entry actually is kind of expected in that case.
@mneudert Did you add that invalid date in the test on purpose?

[mneudert]

Nope, not intended to break this way. Created a small PR to change the date as already suggested.