Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check during date comparison .. #22002

Open
atom-box opened this issue Mar 7, 2024 · 2 comments
Open

Sanity check during date comparison .. #22002

atom-box opened this issue Mar 7, 2024 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Dates & Calendar For bugs and features in date range selections, calendar UI, and report frequency. c: Design / UI For issues that impact Matomo's user interface or the design overall. triaged

Comments

@atom-box
Copy link
Contributor

atom-box commented Mar 7, 2024

Date comparison is allowed for date ranges which are into the future. Is that intended? ..

To reproduce:

  1. Choose a date.
  2. Choose "Compare to" >> Custom >> enter the date from keyboard not from calendar picker

If this behavior is intended, okay to close this without asking me.

image

@atom-box atom-box added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. To Triage An issue awaiting triage by a Matomo core team member labels Mar 7, 2024
@mneudert
Copy link
Member

I would not say this is intended, but it may be worth checking if there is a better way to handle this, or a notice to display in that case.

When selecting date range for the main period you can also select dates in the future, and there may be good use cases for this feature 🤔

@mneudert mneudert added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed To Triage An issue awaiting triage by a Matomo core team member labels Mar 19, 2024
@mneudert mneudert added this to the For Prioritization milestone Mar 19, 2024
@michalkleiner michalkleiner added the c: Dates & Calendar For bugs and features in date range selections, calendar UI, and report frequency. label Mar 19, 2024
@atom-box atom-box changed the title Sanity check during date comparison Sanity check during date comparison .. Jul 12, 2024
@atom-box
Copy link
Contributor Author

test12345

@ronak-innocraft ronak-innocraft added Bug For errors / faults / flaws / inconsistencies etc. and removed Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Dates & Calendar For bugs and features in date range selections, calendar UI, and report frequency. c: Design / UI For issues that impact Matomo's user interface or the design overall. triaged
Projects
None yet
Development

No branches or pull requests

5 participants