Update 1-click trial process to go via Markeplace e-shop

[michalkleiner]

Description:

Ref DEV-18349.

The behaviour on narrower screens was tweaked in dev, that may need adjusting, though I'm not sure what other options are there.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Unrelated to the change, but I notices some of the floating images were overlapping the border, so this fixes it.

[sgiehl]

Generally seems to work as expected. Left a minor translation related comment.

Besides that the UI tests for starting a trial are now failing. Those need to be removed and/or adjusted to cover the new flow.

And I came across one thing that seems weird. For a plugin, which is installed, but the license is missing the super user sees a license missing warning, which is correct. But he normal user has a request trial button, while seeing the no license warning in the details modal. It will most likely not be possible at all to start a new trial in that case, as if the plugin is already installed, there most likely had been a trial or purchase before, so maybe we should simply not show the trial button in that case.

[michalkleiner]

And I came across one thing that seems weird. For a plugin, which is installed, but the license is missing the super user sees a license missing warning, which is correct. But he normal user has a request trial button, while seeing the no license warning in the details modal. It will most likely not be possible at all to start a new trial in that case, as if the plugin is already installed, there most likely had been a trial or purchase before, so maybe we should simply not show the trial button in that case.

@sgiehl what combination of user access level did you use to get the screenshot? I can't reproduce it. When the plugin is installed and license is removed, a super user gets the notification that there's no license, and a regular user gets "More details" (after a tiny change), but a regular user never sees the notification as it requires "hasSomeAdminAccess" to be true.

[michalkleiner]

Besides that the UI tests for starting a trial are now failing. Those need to be removed and/or adjusted to cover the new flow.

@sgiehl removed the Start Free Trial UI tests for now.

[michalkleiner]

And I came across one thing that seems weird. For a plugin, which is installed, but the license is missing the super user sees a license missing warning, which is correct. But he normal user has a request trial button, while seeing the no license warning in the details modal. It will most likely not be possible at all to start a new trial in that case, as if the plugin is already installed, there most likely had been a trial or purchase before, so maybe we should simply not show the trial button in that case.

@sgiehl I've confirmed this was happening for a user that had admin access to another site ("some admin access"). After a change they see 'More details' on the plugin card, no license notification in the modal, but no 'Request trial' within the modal.

[sgiehl]

The previously reported things all seem fixed.
But I came across something else, but as that most likely was already the case before, it might not need to be fixed here.

When running Matomo on PHP 7.2, without a license for premium plugins, as super user it shows the More Details button for LoginSaml. I guess the Start Trial isn't shown, as it requires PHP 7.3. But the modal shows this:

So it shows that it can't be installed, but the warning with the reason is missing.

[michalkleiner]

I've checked how this behaved on 5.0.0 before the on-prem marketplace changes and the warning wasn't shown either for premium plugins. I'll create an internal ticket to follow that up.