-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some metrics requested by customers #22511
Conversation
Converting to draft because it looks like my latest commit broke some tests. |
@snake14 In general it would be good to split up the PR into one PR per metric you want to add and where possible add a test for it. That makes it easier to review and merge it step by step. Note: Time on page won't work that way, as that metric isn't tacked as a normal dimension. Instead it also stores the id of the previous action the stored time is actually valid for. This can't be achieved with a SQL query. |
Thank you @sgiehl . I'll remove the time on page metrics. I've been using my CustomReports PR to test most of the metrics. |
@sgiehl I'm not finding any good examples of testing new metrics in this repo. Could you please point me in the right direction? Do I mock a new report or something? |
Closing in favour of https://github.com/innocraft/plugin-CustomReports/pull/240 |
Description:
Customers have been requesting some metrics be made available in CustomReports, so this PR is trying to add some of those.
Metrics being added:
Internal ticket: PG-3658
Review