Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-17398 Add and use correct marketplace icon #21525

Merged
merged 5 commits into from
Nov 13, 2023
Merged

DEV-17398 Add and use correct marketplace icon #21525

merged 5 commits into from
Nov 13, 2023

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Nov 13, 2023 •
edited
Loading

Description:

Adding and applying new marketplace icon for the nav bar button. Previous icon used was incorrect.

Review

@michalkleiner michalkleiner added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Nov 13, 2023
@michalkleiner michalkleiner added this to the 5.0.0 milestone Nov 13, 2023
@michalkleiner michalkleiner changed the title DEV-17398 Add new marketplace icon DEV-17398 Add and use correct marketplace icon Nov 13, 2023
@michalkleiner michalkleiner mentioned this pull request Nov 13, 2023
Merged
11 tasks
@michalkleiner michalkleiner requested a review from a team November 13, 2023 11:34
@michalkleiner michalkleiner added the Needs Review PRs that need a code review label Nov 13, 2023
@michalkleiner
Copy link
Contributor Author

Review available once the tests finish. UI screenshots updated.

@sgiehl sgiehl merged commit 780f4cd into 5.x-dev Nov 13, 2023
21 of 26 checks passed
@sgiehl sgiehl deleted the dev-17398-marketplace-icon branch November 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @sgiehl