Add clean up task for archive metrics #23907
Merged
+156
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
force-pushed
the
dev-19750-timing-metrics
branch
from
887b7ba to
f08ed6e
Compare
caddoo
force-pushed
the
dev-19776-task
branch
from
7eb6a14 to
1bd6641
Compare
caddoo
force-pushed
the
dev-19776-task
branch
from
1bd6641 to
de6daff
Compare
mneudert
reviewed
Dec 19, 2025
caddoo
force-pushed
the
dev-19776-task
branch
from
de6daff to
06c20b6
Compare
mneudert
approved these changes
Jan 8, 2026
Contributor
|
@caddoo There is a UI screenshot to update here: https://builds-artifacts.matomo.org/matomo-org/matomo/dev-19776-task/20803610208/UIIntegrationTest_admin_diagnostics_configfile.png It adds "ArchivingMetrics" as a new section in the config file. |
caddoo
added a commit
that referenced
this pull request
Jan 16, 2026
* Add clean up task for archive metrics * Add deleted-site purge for archiving metrics * Remove not needed setup/teardown * Add strict types * Update UI screenshot
mneudert
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Add clean up task for archive metrics * Add deleted-site purge for archiving metrics * Remove not needed setup/teardown * Add strict types * Update UI screenshot
caddoo
added a commit
that referenced
this pull request
Jan 19, 2026
* Add archiving metrics code with timer * Pass in segment/period objects where possible * Make plugin not installed by default * Add support back in for segment archiving * Don't prematurely filter plugins * Add additional test for when archive PHP not triggered * Update UI Screenshots * Make archiving_metrics.idarchive not null * Store archiving period as numeric id * Store segment hash in archiving metrics * Derive ts_started from stored start time * Use mocks for Timer tests * Move ArchivingMetrics description to lang file * Tighten ArchivingMetrics integration test * Add strict types and license headers * Move context field extraction into writer * Update screenshots * Store done flag as archive name * Add support for report timings * Remove null check * Update index names * Add check to make sure idArchives array is always 1 * Update index name * Switch to date function * Remove date now() function * Add 'type' to $runs * Add clean up task for archive metrics (#23907) * Add clean up task for archive metrics * Add deleted-site purge for archiving metrics * Remove not needed setup/teardown * Add strict types * Update UI screenshot * Integrate archiveReports with ArchiveMetrics timer (#23906) * Integrate archiveReports with ArchiveMetrics timer * Create event and hook timer into it * Add better typing * Make sure plugin is loaded for integration test * Skip metrics for single-report archiving * Add test-only timer reset helper * Simplify archive loader test GET handling * Add nullable type for instance * cs fix * Add strict types * Allow reports to have metrics recorded * Update test to remove mocked 'now' * Remove report from archiving metrics context * Add report to context only * Clean up test * Update documented parameter order * Update tests to show full year <-> day cascading behaviour * Update expected UI test files --------- Co-authored-by: Marc Neudert <marc@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new metric table can grow, this adds a scheduled task that cleans this up.
Checklist
Basic configurable clean up task for archive metrics
Review