Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of all reimported date ranges in case reimported ranges fall outside initial range #138

Open
diosmosis opened this issue Oct 6, 2020 · 0 comments

Comments

@diosmosis
Copy link
Member

If a user imports a range, then reimports dates outside of that range, there is a danger they may invalidate/re-archive those dates and lose GA data permanently.

The workflow for this bug would be:

  • User imports, eg, 2020-07-01,2020-08-01
  • User re-imports 2020-06-03,2020-06-04
  • User later invalidates 2020-06-03 and re-archives
  • This results in no data displaying for that day

This is due to GoogleAnalyticsImporter::isRequestAuthorizedToArchive() thinking, since the date is not within the main import date range, we can safely re-archive it.

To prevent we need to keep track of every re-imported date range as well the main one.

Note: this is an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant