-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthorizationGA4.php does not respect Matomo proxy setting. #521
Comments
Hi @machinehum . Good catch. Sorry that I missed that in the PR. I'll see if I can create a new PR later today that addresses the GA4 issue. |
Thanks! Looking forward to it. |
We have a PR that we think is ready, but we haven't had confirmation that it works in a proxy setup. If there's anyone that would be willing to test it and confirm whether it solves the problem, we could merge the PR and release a new version of the plugin. |
Sorry! Have been swamped -- I should be able to check this tomorrow (Fri 11
Oct).
…On Tue, Oct 8, 2024 at 4:51 PM Jacob R ***@***.***> wrote:
We have a PR that we think is ready
<#522>,
but we haven't had confirmation that it works in a proxy setup. If there's
anyone that would be willing to test it and confirm whether it solves the
problem, we could merge the PR and release a new version of the plugin.
—
Reply to this email directly, view it on GitHub
<#521 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADTOY6RYBDA5J43BNTVPGIDZ2RHULAVCNFSM6AAAAABG3MM3KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQHA4DIMZQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Hi @machinehum . I hope that you're doing well. Any chance you'll be able to test the PR soon? |
Code to support the Matomo proxy setting was recently added via PR #202. This change applies to
GoogleAnalyticsImporter.googleClient
, which is used byAuthorization.php::getConfiguredClient()
for GA3. However, GA4 does not useGoogleAnalyticsImporter.googleClient
, and a GA4 import from behind a proxy will timeout at the initial OAuth exchange with oauth2.googleapis.com, because the remote host is unreachable.This probably belongs in
GoogleAnalyticsGA4Importer.clientConfiguration
but I'm not entirely sure. Tagging @snake14 since you moved #202 forward.The text was updated successfully, but these errors were encountered: