Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationGA4.php does not respect Matomo proxy setting. #521

Open
machinehum opened this issue Apr 26, 2024 · 5 comments
Open

AuthorizationGA4.php does not respect Matomo proxy setting. #521

machinehum opened this issue Apr 26, 2024 · 5 comments

Comments

@machinehum
Copy link

machinehum commented Apr 26, 2024

Code to support the Matomo proxy setting was recently added via PR #202. This change applies to GoogleAnalyticsImporter.googleClient, which is used by Authorization.php::getConfiguredClient() for GA3. However, GA4 does not use GoogleAnalyticsImporter.googleClient, and a GA4 import from behind a proxy will timeout at the initial OAuth exchange with oauth2.googleapis.com, because the remote host is unreachable.

This probably belongs in GoogleAnalyticsGA4Importer.clientConfiguration but I'm not entirely sure. Tagging @snake14 since you moved #202 forward.

@snake14
Copy link
Contributor

snake14 commented Apr 28, 2024

Hi @machinehum . Good catch. Sorry that I missed that in the PR. I'll see if I can create a new PR later today that addresses the GA4 issue.

@machinehum
Copy link
Author

Thanks! Looking forward to it.

@snake14
Copy link
Contributor

snake14 commented Oct 8, 2024

We have a PR that we think is ready, but we haven't had confirmation that it works in a proxy setup. If there's anyone that would be willing to test it and confirm whether it solves the problem, we could merge the PR and release a new version of the plugin.

@machinehum
Copy link
Author

machinehum commented Oct 10, 2024 via email

@snake14
Copy link
Contributor

snake14 commented Nov 28, 2024

Hi @machinehum . I hope that you're doing well. Any chance you'll be able to test the PR soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants