Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test version.php for PHP7.3 #36

Open
ZerooCool opened this issue Aug 11, 2019 · 5 comments
Open

Add a test version.php for PHP7.3 #36

ZerooCool opened this issue Aug 11, 2019 · 5 comments

Comments

@ZerooCool
Copy link
Contributor

@tsteur
Copy link
Member

tsteur commented Aug 12, 2019

Can you create a PR for that? That'd be great

@ZerooCool
Copy link
Contributor Author

Only those with write access to this repository can merge pull requests.

patch-1 + patch-2

@Findus23
Copy link
Member

Findus23 commented Aug 14, 2019

I don't really understand the use of this new test and hardcoding the version information.
This test already checks for the latest version
https://github.com/matomo-org/plugin-SecurityInfo/blob/e5994c355d0a4cb502749e2085b9ed67c9d4e282/PhpSecInfo/Test/Application/php.php

And if you dislike deserializing data, you could also simply use https://www.php.net/releases/?json=1&version=7

@tsteur
Copy link
Member

tsteur commented Aug 14, 2019

BTW: We can ping external URLs only if \Piwik\SettingsPiwik::isInternetEnabled() is enabled

@ZerooCool
Copy link
Contributor Author

Then use relative link ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants