-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test version.php for PHP7.3 #36
Comments
Can you create a PR for that? That'd be great |
Only those with write access to this repository can merge pull requests. patch-1 + patch-2 |
I don't really understand the use of this new test and hardcoding the version information. And if you dislike deserializing data, you could also simply use https://www.php.net/releases/?json=1&version=7 |
BTW: We can ping external URLs only if |
Then use relative link ? |
The Json file
https://github.com/ZerooCool/phpsecinfo/blob/phpsecinfo-zeroocool-v0.2.1/20070406-phpsecinfo-v0.2.1/.version.json
The file version.php
https://github.com/ZerooCool/phpsecinfo/blob/phpsecinfo-zeroocool-v0.2.1/20070406-phpsecinfo-v0.2.1/PhpSecInfo/Test/Core/version.php
I change it for PHP 7.3 value.
The text was updated successfully, but these errors were encountered: