-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSS bot] Include items lacking certain fields (e.g. <title>) #888
Comments
Related: withastro/astro#9577 |
Note that title element is optional in RSS. Mastodon is producing valid feeds. |
Sorry, to clarify are you saying Hookshot is skipping entries without a title entirely? |
This is our present understanding (i.e., the major observable difference between a feed that can be followed by Hookshot and one that can not), but we have not bisected it at an XML level - should probably better be done in a unit test |
From my testing (https://github.com/matrix-org/matrix-hookshot/tree/hs/check-mastodon-style-rss-feeds), this doesn't seem to be the case. When we encounter a mastodon-style feed, the result is:
|
Could you please share a link to a Mastodon feed that is fetched correctly so I can test it myself? Maybe you have blocked some of the feeds we are subscribed to. |
I have seen quite random behavior with Feeds bot recently. I thought the "bug" was fixed but then some feeds don't seem to work randomly. This is starting to sound like issue with the Feeds bot operated by Element. Not sure where that should be reported to. |
If you can give me a working Mastodon feed link, then this issue can be closed, as the root cause then may be #844 |
https://sauna.social/tags/leffat.rss (a hashtag feed) provided a toot yesterday. |
Also me, via element-hq/element-integration-manager#108. It sounds like this is a skipping entries bug for sure. |
Due to this issue, Mastodon feed subscription doesn't work.
Some feeds may be produced by buggy software, and thus lack some of the fields many developers assume to be mandatory. When possible, items could still be synthesized via generic text.
All what is really required from a user perspective in an item is a link that the user can click on
link
is missing, try to parse theguid
orid
as a link. Lacking that, post a link to the origin instead so the user could still get notified when something is new and check it out manually.title
is missing, show the date, feed name or some generic link text insteadThe text was updated successfully, but these errors were encountered: