Skip to content

Conversation

@Hywan
Copy link
Member

@Hywan Hywan commented Nov 4, 2025

The database has been updated but the version hasn't been bumped.


The database has been updated but the version hasn't been bumped.
@Hywan Hywan requested review from poljar and richvdh November 4, 2025 13:25
@Hywan Hywan requested a review from a team as a code owner November 4, 2025 13:25
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (49db60d) to head (9753c38).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5829   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         361      361           
  Lines      101533   101533           
  Branches   101533   101533           
=======================================
+ Hits        89915    89923    +8     
+ Misses       7407     7400    -7     
+ Partials     4211     4210    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but it would be good to think about how we to avoid someone else making the same mistake.

Maybe an assertion that txn.get_db_version() == DATABASE_VERSION at the end of run_migrations would be sufficient?

@Hywan
Copy link
Member Author

Hywan commented Nov 4, 2025

I'll open a PR to address that. Thanks for the suggestion.

@Hywan Hywan merged commit 81ff96d into matrix-org:main Nov 4, 2025
52 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #5829 will not alter performance

Comparing Hywan:fix-sqlite-crypto-store-version-12 (9753c38) with main (49db60d)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants