Fix array comparison #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses edit distance to generate optimal seq for simple arrays. Fixes #1
* Append edit distance operations from end to start * Tests patches from src->dst and dst->src using github.com/evanphx/json-patch * Fix Null test case
|
Anyone interested in this fix, consider using our fork https://github.com/appscode/jsonpatch |
mengqiy
reviewed
Jan 7, 2019
|
|
||
| type JsonPatchOperation struct { | ||
| type Operation struct { |
There was a problem hiding this comment.
@tamalsaha Why changing the name?
Controller-runtime is considering switching to use appscode's fork.
But it can be a problem for the existing users due to the breaking change.
There was a problem hiding this comment.
I am not sure what can we do in our fork. Will adding a type alias help?
There was a problem hiding this comment.
I have added the type alias to 1.0.0 release.
tamalsaha
added a commit
to gomodules/jsonpatch
that referenced
this pull request
Jan 8, 2019
xref: mattbaird#13 (comment) Signed-off-by: Tamal Saha <[email protected]>
tamalsaha
added a commit
to gomodules/jsonpatch
that referenced
this pull request
Jan 8, 2019
xref: mattbaird#13 (comment) Signed-off-by: Tamal Saha <[email protected]>
|
Hey everyone :) ! |
|
@maeglindeveloper , I maintain a fork here https://github.com/gomodules/jsonpatch/tree/release-2.0 . Feel free to use that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses edit distance to generate optimal seq for simple arrays.
Fixes #7