Fix accidental escaping of SiteURL (#35)

enzowritescode · web-flow · commit 1e83bd6f1c89 · 2024-11-21T09:04:53.000-07:00
diff --git a/server/plugin/api.go b/server/plugin/api.go
@@ -702,7 +702,7 @@ func (p *Plugin) openCommentReplyDialog(c *Context, w http.ResponseWriter, r *ht
 	commentID := request.Context["commentID"].(string)
 	fileID := request.Context["fileID"].(string)
 	urlStr := fmt.Sprintf("%s/plugins/%s/api/v1/reply?fileID=%s&commentID=%s",
-		url.PathEscape(*p.API.GetConfig().ServiceSettings.SiteURL),
+		*p.API.GetConfig().ServiceSettings.SiteURL,
 		url.PathEscape(Manifest.Id),
 		url.QueryEscape(fileID),
 		url.QueryEscape(commentID))
diff --git a/server/plugin/oauth.go b/server/plugin/oauth.go
@@ -38,7 +38,7 @@ func (p *Plugin) getOAuthConfig() *oauth2.Config {
 	}
 
 	redirectURL := fmt.Sprintf("%s/plugins/%s/oauth/complete",
-		url.PathEscape(*p.Client.Configuration.GetConfig().ServiceSettings.SiteURL),
+		*p.Client.Configuration.GetConfig().ServiceSettings.SiteURL,
 		url.PathEscape(Manifest.Id))
 
 	return &oauth2.Config{

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func (p Plugin) getOAuthConfig() oauth2.Config {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`redirectURL := fmt.Sprintf("%s/plugins/%s/oauth/complete",`
`41`		`- url.PathEscape(*p.Client.Configuration.GetConfig().ServiceSettings.SiteURL),`
	`41`	`+ *p.Client.Configuration.GetConfig().ServiceSettings.SiteURL,`
`42`	`42`	`url.PathEscape(Manifest.Id))`
`43`	`43`
`44`	`44`	`return &oauth2.Config{`