Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting and stopping the notifications slash commands are not working #5

Open
AayushChaudhary0001 opened this issue Jul 11, 2024 · 9 comments
Assignees

Comments

@AayushChaudhary0001
Copy link

AayushChaudhary0001 commented Jul 11, 2024

As a user, the notifications for commenting and sharing any file type in the drive are not working.

Steps to reproduce:-

  1. Run the "/drive notifications start".
  2. Share the desired file from the drive to a user and add a comment on it.
  3. Go back to MM and open the bot channel.

The user did not receive the notification for the file type shared and comment added.

And since, the start notification functionality is not working we cannot assure that the stop functionality would be working properly or not.

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 can you share details about your MM setup and steps to reproduce the issue because it was working in my testing. Just want to confirm that it's not some configuration issue before diving into debugging.

@wiggin77
Copy link
Collaborator

@AayushChaudhary0001 can you provide more information per above?

@AayushChaudhary0001
Copy link
Author

AayushChaudhary0001 commented Jul 31, 2024

@darkLord19 I am using an enterprise edition of Mattermost (version:- 7.1.0). Also, for plugin, I have created the build from master branch. I have already configured the client ID and client secret, as I am able to connect the account.

Steps to reproduce:-

  1. Run the "/drive notifications start".
  2. Share the desired file from the drive to a user and add a comment on it through the account of the user to whom the file is shared.
  3. Go back to MM and open the bot channel of Google Drive.

What I did is share a document which was created in my drive to a user and add comments through that user's account. The notifications were already enabled still I didn't get any notification on MM instance.

I am also adding a supporting screenshot below.

image

I am also attaching the logs which I have received.

{"timestamp":"2024-07-31 10:30:48.954 Z","level":"error","msg":"failed to get comment","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 404: File not found: fouj3t1ijfncbcfrngs51srn4c., notFound","commentID":"AAABS4wJvKo"}
{"timestamp":"2024-07-31 10:31:04.545 Z","level":"error","msg":"failed to get comment","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 404: File not found: fouj3t1ijfncbcfrngs51srn4c., notFound","commentID":"AAABS4wJvLI"}

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 did you comment using your own account? Comments made using the same account which is connected to mattermost won't trigger notifications.

@darkLord19
Copy link
Contributor

You will need two accounts for this.

  1. create a file using account linked to your mm profile
  2. comment of that file using some other account

@AayushChaudhary0001
Copy link
Author

@darkLord19 No, the account which I used for commenting is another user's account.

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 please use this branch #12 and see if everything is working correctly.

Please see attached videos i have done clean setup on my device and it's working fine
https://drive.google.com/drive/folders/1iUckXDK_YKB2T48Ry2Cxa229dKpq6irB?usp=sharing

@AayushChaudhary0001
Copy link
Author

@darkLord19 Tested PR #12 works fine for the login is a user comments, but there is an issue in the UI with the Indigo theme of Mattermost, can you please look into it?

I am attaching a screenshot as well for the same

image

Also, in other plugins blue coloured button is used in these type of attachments, if you can try to make it consistent in any way

image

@darkLord19
Copy link
Contributor

@AayushChaudhary0001 can you close this issue and create a new one for theming issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants