Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM Build. #211

Closed
mezoology opened this issue Aug 15, 2023 · 4 comments · Fixed by #230
Closed

ARM Build. #211

mezoology opened this issue Aug 15, 2023 · 4 comments · Fixed by #230
Milestone

Comments

@mezoology
Copy link

mezoology commented Aug 15, 2023

Im usimg MM on an ARM node, couldn't make TODO work at all. always throwing this error:

This plugin failed to start. unable to start plugin: com.mattermost.plugin-todo: unable to generate plugin checksum: read plugins/com.mattermost.plugin-todo: is a directory

after digging for a bit, in plugin.json :

"server": {
        "executables": {
            "linux-amd64": "server/dist/plugin-linux-amd64",
            "darwin-amd64": "server/dist/plugin-darwin-amd64",
            "windows-amd64": "server/dist/plugin-windows-amd64.exe"
        },

which does not include an ARM binary.

so is there any chance of binaries compiled for ARM ? I tried to compile it myself using the 'Makefile' but had no success, as I have no experience in Typescript/Java.

at least guide me to the correct way to compile it on my node.

@rahulsuresh-git
Copy link
Contributor

@mickmister Do you think I should raise a PR with the fix that we had performed on #228 ?

@mickmister
Copy link
Contributor

@rahulsuresh-git Sure that sounds good to me. Ideally we do a full sync with the starter template. Maybe I'll just do that in #229 since I'm updating the dependencies anyway

@mickmister
Copy link
Contributor

@rahulsuresh-git We can go with just updating the necessary things for the ARM build actually. We can merge the PR for that right away that way

@rahulsuresh-git
Copy link
Contributor

rahulsuresh-git commented Nov 14, 2023

Sounds good, I'll get at it. @mickmister

mickmister pushed a commit that referenced this issue Nov 16, 2023
* added github workflow for playwright

* removed github workflow for playwright

* added support for arm processors like Apple Silicon
@avas27JTG avas27JTG added this to the v1.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants