Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data directly without checking paths #359

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

engahmeds3ed
Copy link

Sometimes we need to use our own checks if path is found or not so we don't need to run the following code over it

https://github.com/engahmeds3ed/minify/blob/4eeda08af72a1012202e0dc7d99436f06714b086/src/Minify.php#L471

for example we have our own filesystem the is being replaced while running tests to use virtual filesystem so on this case is_file and is_readable won't work properly.

also another example, if I have file path and I need to do some changes on the content itself then send it to be minified ( assume also this file has some imports that need to be replaced ) so I need to pass the path along with the modified contents.

I hope u can do code review and validate quickly, thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant