Add data directly without checking paths #359
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to use our own checks if path is found or not so we don't need to run the following code over it
https://github.com/engahmeds3ed/minify/blob/4eeda08af72a1012202e0dc7d99436f06714b086/src/Minify.php#L471
for example we have our own filesystem the is being replaced while running tests to use virtual filesystem so on this case is_file and is_readable won't work properly.
also another example, if I have file path and I need to do some changes on the content itself then send it to be minified ( assume also this file has some imports that need to be replaced ) so I need to pass the path along with the modified contents.
I hope u can do code review and validate quickly, thanks in advance.