Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Promise reject error #214

Open
zanminkian opened this issue Nov 30, 2024 · 0 comments
Open

Feature request: Promise reject error #214

zanminkian opened this issue Nov 30, 2024 · 0 comments

Comments

@zanminkian
Copy link

zanminkian commented Nov 30, 2024

new Promise((resolve, reject) => {
  if (Math.random() > 0.5) {
    resolve("foo");
  } else {
    reject("bar"); // We should `reject(new Error("bar"))`
  }
});
Promise.reject("foo"); // We should `reject(new Error("foo"))`

Rejecting a non Error variable is bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant