Please merge themes #118
Comments
|
👍 |
|
So where is the author of this repository? |
|
Not a clue I'm afraid, I reached out to him on Twitter but no luck! |
|
@mattvh it has been over two months since you last merged any PRs on this repo. If you're struggling to find time then I would like to offer my help, I'm happy to review PRs for you (and ensure the same standards that you do) as well as keeping the site up to date and even implementing some of the things I mentioned in #104. I'm sure lots of people would agree that this is a good idea! @mx3m @Gaohaoyang @diezcami @karloespiritu @DigitalMindCH @smallmuou @SpaceG @mushishi78 @nmenag @kevit @qckanemoto @arniekoz @ariestiyansyah @parkr |
|
Absolutely Agree! |
|
we would be pretty glad as well! |
|
Sounds good and I completely agree! 🍻 |
|
Agree with @jacobtomlinson , We can help maintain this repo. Anyway if we dont get update from @mattvh I suggest to create new site, I can buy new domain if you need. cc @mx3m @Gaohaoyang @diezcami @karloespiritu @DigitalMindCH @smallmuou @SpaceG @mushishi78 @nmenag @kevit @qckanemoto @arniekoz @parkr |
|
There was some talk about moving this to the jekyll org, but that has not happened yet. |
|
@ariestiyansyah I agree and the same thought had crossed my mind. @parkr would it be possible to fork this repository into the jekyll org and host it on github pages under themes.jekyllrb.com? Then setup myself, @mattvh and @ariestiyansyah with push access? I'm happy to spend some time updating the website itself and bringing it in line with the rest of the jekyll website. |
|
I think this would be great. I was lucky that @mattvh updated the website. It gave my theme a lot of boost and interested people. Without jekyllthemes.org that would have not happened. I would advise to make a themes.jekyllrb.com website. It's the best thing to drive even more people into Jekyll and make them to use it. I am an admirer of how Automattic pushed WordPress by building a community site like wordpress.org. For me as a – at best – mediocre programmer the starting point developing with a new tool is to look at other peoples work. That's the power of open source. And if Matt has no time for this project, it would be great if people like @jacobtomlinson help out. |
|
I'd be happy to help out as well - I could help merge pull requests and perhaps tweak the current layout, if you guys don't mind. |
|
@ariestiyansyah It's a great idea. I can help review codes too. We can do together and make it better! |
|
Just requested sub-domain from jekyllrb creator, I'll update when I get good news. |
|
Nice |
|
Thank you so much!!! 发自我的 iPhone
|
|
Please check the discussion in this issue jekyll/jekyll#3749 |
|
Absolutely Agree! |
|
Since the discussion on jekyll/jekyll#3749 is closed I decided to send email to @parkr asking about providing subdomain or create new site. If Jekyll can't provide the subdomain let's poll for new domain and I'll create the repository of it
|
|
I vote for jekyll-themes.org.
|
|
Agree jekyll-themes.org |
|
Agree jekyll-themes.org Pawpaw [email protected]于2015年6月2日星期二写道：
|
|
I see it's good domain name, I'll buy the doman in Thursday or Friday. At this I try move the code to new repository here https://github.com/ariestiyansyah/jekyllthemes and plan to change the web design. Please start contribute to the new repo. |
|
Ok, I will start contribute to the new repo. Original Message Sender: Rizky [email protected]: mattvh/[email protected]: [email protected]: Tuesday, Jun 2, 2015 19:45Subject: Re: [jekyllthemes] Please merge themes (#118)I see it's good domain name, I'll buy the doman in Thursday or Friday. At this I try move the code to new repository here https://github.com/ariestiyansyah/jekyllthemes and plan to change the web design. Please start contribute to the new repo. —Reply to this email directly or view it on GitHub. |
|
Yep me too! |
|
You should start by pulling in the open PRs from mattvh/jekyllthemes. And it would be good to have more than one person with push access to your repo, to avoid this from happening again. Could you please give me push access. |
|
Done @jacobtomlinson Pleae move all the conversation to ariestiyansyah/jekyllthemes#2 |
|
Did anyone try talking to @mattvh? |
|
@parkr Some of us are contacted him but no respond, anyway please respond to my email so we get answer if we can start themes.jekyllrb.com or not (create another one) |
|
@parkr yeah I've tried multiple times through GitHub, Twitter and email. |
|
Sorry I've been so out of contact lately. I was busy, then sick for three weeks. I'll try to get things merged back up soon. |
|
Ok done. |
|
@mattvh great to see you're back! Hope you're feeling better. It would be great if this could be avoided in future, I notice that it isn't the first time that PRs have been left for a few months. Would you consider letting someone else help you out? |
|
? |
|
@mattvh available again these days? Please add @jacobtomlinson , @ariestiyansyah and @gynter as contributors. |
|
No clue, haven't had any contact from him. |
|
This happens regularly, @mattvh only checks this repo every couple of months. It's a shame because I think this project would be even better if it was maintained properly. @gynter has done some excellent work on it and greatly improved it, and yet even he hasn't been made a contributor with merge permissions. @geraldb has started a competing project called Dr Jekyll's Themes and he appears to maintain it very well. Personally I disagree with his move away from pure Jekyll for the project but it is probably a better option than this one now. jekyllthemes.io also exists, it looks really nice but doesn't appear to be open source and puts more emphasis on selling premium themes. |
|
Hello, FYI: Dr Jekyll's Themes is NOT competing. It's just another alternative. (it's different e.g. includes a theme package manager and a script wizard etc. and some more). The site is a "pure" GitHub Pages (Jekyll) site. To make it easier to contribute it uses a gitsubmodule for /themes All code incl. "the build (pre-processing) step" (see the /build repo) is open and public domain. Cheers. PS: The themes.yml file is designed for easy (re)use - similar to the static site listing, for example, see bevry/staticsitegenerators-list. Cheers. |
|
Great thanks for the clarification. I was referring to the fact that it requires a build script and that you can't fork the repo and have it would just work with GitHub Pages without some extra configuration and creation/maintaining of build servers. We (@ariestiyansyah and I) already tried forking the repo but a few days after we did @mattvh came back, merged everything on here and assured us he would merge more often. We also spoke to @parkr about themes.jekyllrb.com and he basically said a lot will change with Jekyll 3's themes and plugins and that he wanted to hold off on that for now. |
To add to what Jacob said, another problem is that in the case of a fork, themes.jekyllrb.org will compete with jekyllthemes.org for Google ranking, and there will be Yet Another Themes Site on the web competing for users' attention. Right now, jekyllthemes.org is very established. It would be much better if it could be continuously maintained by a group of Jekyll contributors for a while, and then be migrated (and redirect to) themes.jekyllrb.org in due time. |
|
I agree with @erlend-sh, another fork would just bring up more confusion. @jacobtomlinson I don't see why the page couldn't be built via Github pages. It seems to be work fine when testing with |
|
@gynter I was talking about Dr Jekyll's Themes not this one 😄. And yes I agree with @erlend-sh. |
|
Just one more time: Be bold, stop talking and complaining. Show us how to to do it. Lead by example and action. Do NOT worry about the google ranking. If you work hard the new directory will rise up. It's that easy ;-) There's no confusion. Let's welcome and celebrate more theme directories. PS: If you use a public domain "un-license" it's easy to keep the yaml listing in sync, for example and so on. After all it's just data. Cheers. |
|
I made a fork: themes-jekyll.github.io I re-wrote the site from scratch with the following changes:
I've left I appreciate that it's a lost cause trying to rank a new site if we're going to move onto themes.jekylrb.com. However, perhaps there's something to @geraldb's notion of "leading by example". @mattvh can always merge changes back in if he wants, and group repository could serve as a better starting point before making the move over to the official domain. |
|
Okay, that's a pretty convincing argument there @mushishi78 , nice work! 👏 I could get on board with supporting that fork. Like you said, it can always be merged back in, which would ideally coincide with the addition of some new contributors, which seems more likely with the addition of these improvements. |
|
@erlend-sh @jacobtomlinson @gynter @ariestiyansyah I've presumptuously given you guys admin access, if you don't want to be involved, feel free to ignore it. I've also added an experimental preview demos page that can be removed if no-one wants it. |
|
@mushishi78 Great initiative. Keep it up. Will try to promote the new theme directory e.g. first tweet here, and a post here and another here. Cheers. (Update: I've updated the links in the postings to use the new themes.jekyllrc.org domain. Keep it up.) |
|
For anyone on this thread whose interested, the new fork has been moved to jekyllrc/jekyllthemes as @gynter wanted to have an umbrella organisation to manage other jekyll projects that might need forking. Thanks @geraldb for your promotion :) |
|
Cool, let's do the best! On Mon, Sep 7, 2015 at 6:53 PM, Max White [email protected] wrote:
Rizky Ariestiyansyah |
Add tasks folder to Jekyll exclude list
It is a long time after you merged pull requests last time. May be you are busy. If you have time, please merge 13 new themes.
I'd glade to see that.
The text was updated successfully, but these errors were encountered: