Skip to content

Commit

Permalink
NIFI-13111: Removing/Hiding unimplemented features in preparation for…
Browse files Browse the repository at this point in the history 
… next milestone release (apache#8710)

* NIFI-13111:
- Removing/Hiding unimplemented features in preparation for next milestone release.

* NIFI-13111:
- Addressing review feedback.

 This closes apache#8710
  • Loading branch information
@mcgilman
mcgilman authored May 1, 2024
1 parent d487ce4 commit f70967e
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 32 deletions.
18 changes: 12 additions & 6 deletions ...frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
menuItems: [
{
condition: (selection: any) => {
return this.canvasUtils.hasUpstream(selection);
// TODO - hasUpstream
return false;
},
clazz: 'icon',
text: 'Upstream',
Expand All @@ -303,7 +304,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
return this.canvasUtils.hasDownstream(selection);
// TODO - hasDownstream
return false;
},
clazz: 'icon',
text: 'Downstream',
Expand Down Expand Up @@ -819,7 +821,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
return this.canvasUtils.isProcessGroup(selection);
// return this.canvasUtils.isProcessGroup(selection);
return false;
},
clazz: 'fa fa-flash',
text: 'Enable all controller services',
Expand All @@ -829,7 +832,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
return this.canvasUtils.emptySelection(selection);
// return this.canvasUtils.emptySelection(selection);
return false;
},
clazz: 'fa fa-flash',
text: 'Enable all controller services',
Expand All @@ -839,7 +843,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
return this.canvasUtils.isProcessGroup(selection);
// return this.canvasUtils.isProcessGroup(selection);
return false;
},
clazz: 'icon icon-enable-false',
text: 'Disable all controller services',
Expand All @@ -849,7 +854,8 @@ export class CanvasContextMenu implements ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
return this.canvasUtils.emptySelection(selection);
// return this.canvasUtils.emptySelection(selection);
return false;
},
clazz: 'icon icon-enable-false',
text: 'Disable all controller services',
Expand Down
19 changes: 10 additions & 9 deletions ...flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,16 @@
(click)="group(selection)">
<i class="ml-1 icon icon-group"></i>
</button>
<button
mat-icon-button
color="primary"
class="mr-2"
type="button"
[disabled]="!canColor(selection)"
(click)="color(selection)">
<i class="fa fa-paint-brush"></i>
</button>
<!-- TODO - Add support for coloring processors and labels -->
<!-- <button-->
<!-- mat-icon-button-->
<!-- color="primary"-->
<!-- class="mr-2"-->
<!-- type="button"-->
<!-- [disabled]="!canColor(selection)"-->
<!-- (click)="color(selection)">-->
<!-- <i class="fa fa-paint-brush"></i>-->
<!-- </button>-->
<button
mat-icon-button
color="primary"
Expand Down
11 changes: 10 additions & 1 deletion .../connection-status-listing/connection-status-table/connection-status-table.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,16 @@
<ng-container matColumnDef="moreDetails">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center gap-x-2"></div>
@if (canRead(item)) {
<div class="flex items-center gap-x-2">
<!-- TODO - support showing connection details in EditConnectionDialog -->
<!-- @if (canRead(item)) {-->
<!-- <div-->
<!-- class="pointer fa fa-info-circle primary-color"-->
<!-- title="View Connection Details"></div>-->
<!-- }-->
</div>
}
</td>
</ng-container>

Expand Down
11 changes: 1 addition & 10 deletions ...group-status-listing/process-group-status-table/process-group-status-table.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,7 @@
<ng-container matColumnDef="moreDetails">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
@if (canRead(item)) {
<div class="flex items-center gap-x-2">
<!-- TODO - handle read only in configure component? -->
@if (canRead(item)) {
<div
class="pointer fa fa-info-circle primary-color"
title="View Process Group Details"></div>
}
</div>
}
<div class="flex items-center gap-x-2"></div>
</td>
</ng-container>

Expand Down
12 changes: 6 additions & 6 deletions .../ui/processor-status-listing/processor-status-table/processor-status-table.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@
<td mat-cell *matCellDef="let item">
@if (canRead(item)) {
<div class="flex items-center gap-x-2">
<!-- TODO - handle read only in configure component? -->
@if (canRead(item)) {
<div
class="pointer fa fa-info-circle primary-color"
title="View Processor Details"></div>
}
<!-- TODO - support showing processor details in EditProcessorDialog -->
<!-- @if (canRead(item)) {-->
<!-- <div-->
<!-- class="pointer fa fa-info-circle primary-color"-->
<!-- title="View Processor Details"></div>-->
<!-- }-->
</div>
}
</td>
Expand Down

0 comments on commit f70967e

Please sign in to comment.