Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of a unescape/safe helper when autoescape in on #108

Open
n1k0 opened this issue Jan 26, 2012 · 1 comment
Open

Lack of a unescape/safe helper when autoescape in on #108

n1k0 opened this issue Jan 26, 2012 · 1 comment

Comments

@n1k0
Copy link

n1k0 commented Jan 26, 2012

When using cofeekup with express and enabling autoescape, the @body property in the layout will be escaped as well; it should not.

# sample express application - app.coffee

app.configure ->
    @set "view options", autoescape: true # autoescaping enabled
    @set "views", "#{__dirname}/views"
    @set "view engine", "coffee"
    @register '.coffee', coffeekup.adapters.express
# layout.coffee

doctype 5
html -> body -> @body # <-- body contents will be escaped, including 
                      #     markup generated by coffeekup itself!

What would be especially cool is a safe helper:

# layout.coffee

doctype 5
html -> body -> safe @body # <-- tags generated by coffeekup wouldn't be 
                           #     escaped, only variables would)

What do you think? I can work on a patch and send a PR if you agree on this.

@n1k0
Copy link
Author

n1k0 commented Jan 26, 2012

For the record, this is a quick workaround:

doctype 5
html -> body ->
    @autoescape = false
    @body

I keep thinking that a safe helper is needed though :)

n1k0 added a commit to n1k0/coffeekup that referenced this issue Jan 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant