Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a new release soon please #316

Open
vesper8 opened this issue Nov 5, 2023 · 10 comments
Open

Can we get a new release soon please #316

vesper8 opened this issue Nov 5, 2023 · 10 comments

Comments

@vesper8
Copy link

vesper8 commented Nov 5, 2023

@escopecz Sorry to bother you but there have been 95 commits since the last release over a year ago and now this logger issue is causing a lot of trouble for people who have upgraded to Laravel 10. Any chance you could tag a new release soon pretty please?

Many thanks!!

@escopecz
Copy link
Member

escopecz commented Nov 6, 2023

@mollux do you want to get something else in or can we tag v4.0.0?

@mooror
Copy link

mooror commented Dec 1, 2023

I would also request a new release as we are experiencing 8.1 strlen() null errors that I believe may have been fixed in issue #293 but are yet to be released (but please correct me if I am mistaken)

@bradjones1
Copy link

Who's the current primary maintainer of this package? A new release tag would be amazing.

@broskees
Copy link

Overriding classes currently, would also love a new tag. Thank you!

@RCheesley
Copy link
Member

Hi folks! I've set up a milestone so you can see what we are hoping to include in the 4.0.0 release.

Your help would be very much appreciated in testing - this can be done using DDEV which sets everything up for you, check the readme for more guidance. Any PR with 'ready to test' needs to be tested. Thanks in advance! 🚀

@jhm-ciberman
Copy link

+1 to get a new release. Currently this is blocking us from integrating Mautic in our company.

@RCheesley
Copy link
Member

@jhm-ciberman there's one PR waiting for testing in the milestone. Please test it and leave a review, and we can ship a release. Test instructions are in the readme, and you can also read https://contribute.mautic.org/contributing-to-mautic/tester#leaving-your-review for how to leave a review on the PR. Thanks!

@jhm-ciberman
Copy link

Hi @RCheesley! Sadly I don't have the knowledge required to review the PR since this is the first time we are using Mautic in our company and this is the first time I use Mautic too.

In our company we are just starting to integrate Mautic to our backend infrastructure, but we haven't started yet since #286 is blocking us from integrating mautic/api-library with our Laravel Backend via https://github.com/swisnl/laravel-mautic. (See swisnl/laravel-mautic#39 (comment)).

I would love to contribute to the project, however I don't feel familiarized enough with Mautic in order to review this particular PR. However, as far as I understand, this PR is a new feature, not a bug fix or even a breaking change. So it can be easily released on a next minor release cycle (e.g v4.1.0) after it's carefully tested and reviewed. The PR only adds an extra class (Mautic\Auth\TwoLeggedOAuth2) without modifying any existing public API. Since that is not a breaking change, it could be released on any minor release without breaking SemVer compatibility.

However, a lot of PRs and fixes currently included in v4.0.0-beta are blocking (Not only for me but for other package consumers too). It would be a shame that all the hard work made by the contributors with those fixes gets delayed because a single feature PR is blocking the release.

If this PR is really necessary in order to release, I could check in our company if we can reach some mautic developer with more experience to review that PR, but I think that's unlikely since it's our first time integrating Mautic.

Sorry if this sounded demanding. I know Open Source can be stressful with all people demanding things but not collaborating to the project. If there is any way I can help, please let me know.

Thanks! 😄

@mooror
Copy link

mooror commented Jan 31, 2025

@jhm-ciberman Well said.

@escopecz
Copy link
Member

@jhm-ciberman thanks for your understanding the challenges. The release was made as a beta: https://github.com/mautic/api-library/releases/tag/4.0.0-beta

Is there some problem to use that via Composer? Or what is the blocker?

I'm trying to understand the urgency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants