diff --git a/mayan/apps/dependencies/classes.py b/mayan/apps/dependencies/classes.py index 2de09e32afb..5df57a68767 100644 --- a/mayan/apps/dependencies/classes.py +++ b/mayan/apps/dependencies/classes.py @@ -530,7 +530,29 @@ def extract(self, replace_list=None): path_compressed_file = self.get_tar_file_path() with tarfile.open(name=force_text(s=path_compressed_file), mode='r') as file_object: - file_object.extractall(path=temporary_directory) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(file_object, path=temporary_directory) self.patch_files(path=temporary_directory, replace_list=replace_list)