Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 2fa not working as expected #14

Open
pi-sigma opened this issue Feb 8, 2024 · 2 comments
Open

Disable 2fa not working as expected #14

pi-sigma opened this issue Feb 8, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@pi-sigma
Copy link

pi-sigma commented Feb 8, 2024

2fa can be disabled for staff + superusers that don't have a TOTP device set up, but as as soon as you enable 2fa, you're stuck with it for that user (in the sense that it cannot be disabled programmatically).

Not a big hassle for development purposes, as you can just create a new superuser for testing out 2fa. However, it's not intuitive and should be either fixed or documented at some point.

@sergei-maertens
Copy link
Member

You can also delete the TOTP/WebAuthn device in the admin for that user and then everything works as expected again.

I'm a little bit hesitant to special-casing this in the login flow since it introduces a risk for potential security issues if mistakes are made in how this is handled.

@pi-sigma
Copy link
Author

Sounds right, it adds an extra step, but it's only relevant for testing this particular feature anyway.

@sergei-maertens sergei-maertens added the documentation Improvements or additions to documentation label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants