Merge pull request #134 from maykinmedia/issue/127-Lazy-LOGIN_URL-breaks-rosettas-login-URL-functionality

🐛 #127 Fix: Lazy LOGIN_URL breaks rosetta's login URL functionality

Author: stevenbal

open_api_framework/conf/base.py

@@ -564,8 +564,7 @@
     help_text="For how long, in seconds, the session cookie will be valid.",
 )
 
-
-LOGIN_URL = reverse_lazy("admin:login")
+LOGIN_URL = "admin:login"
 LOGIN_REDIRECT_URL = reverse_lazy("admin:index")
 LOGOUT_REDIRECT_URL = reverse_lazy("admin:index")
 

pyproject.toml

@@ -75,6 +75,8 @@ tests = [
     "black",
     "flake8",
     "factory-boy",
+    "django-rosetta",
+    "django-webtest"
 ]
 coverage = [
     "pytest-cov",

testapp/settings.py

@@ -28,6 +28,8 @@
     ),
     auto_display_default=False,
 )
+STATIC_URL = "/static/"
+LOGIN_URL = "admin:login"
 
 USE_TZ = config("USE_TZ", True, add_to_docs=False)
 
@@ -47,6 +49,7 @@
     "open_api_framework",
     "sessionprofile",
     "testapp",
+    "rosetta",
 ]
 
 MIDDLEWARE = [

tests/test_settings.py

@@ -1,8 +1,26 @@
+from django.conf import settings
+from django.urls import reverse
+
+import requests_mock
+from django_webtest import WebTest
+
+
 def test_sentry_settings():
     """
     test that sentry settings are initialized
     """
-    from django.conf import settings
 
     assert hasattr(settings, "SENTRY_CONFIG") is True
     assert hasattr(settings, "SENTRY_DSN") is True
+
+
+@requests_mock.Mocker()
+class RosettaTests(WebTest):
+    def test_rosetta_redirect_fails_with_lazy_login_url(self, m):
+        response = self.app.get("/admin/rosetta/files/project/")
+
+        expected_login_url = (
+            reverse(settings.LOGIN_URL) + "?next=/admin/rosetta/files/project/"
+        )
+        self.assertEqual(response.status_code, 302)
+        self.assertEqual(response.location, expected_login_url)

tox.ini

@@ -26,6 +26,8 @@ extras =
     tests
     coverage
 deps =
+  django-rosetta
+  django-webtest
   django42: Django~=4.2.0
   django51: Django~=5.1.0
 commands =