👷 [maykinmedia/objects-api#463] Add trivy image scan #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/add-trivy-image-scan
branch
3 times, most recently
from
e54584e
to
b57c85e
Compare
stevenbal
force-pushed
the
feature/add-trivy-image-scan
branch
from
b57c85e
to
29724c4
Compare
|
I'll add it to the other components once this PR is merged |
annashamray
reviewed
Oct 25, 2024
There was a problem hiding this comment.
In ON PR I can see that the workflow was successfully completed (inluding the uploading to Security tab part), but I can't find the results there:
https://github.com/open-zaak/open-notificaties/security/code-scanning/tools/Trivy/status
It looks like the last results were in September. Do I look in the incorrect place?
|
@annashamray hmm strange, maybe it only shows results for main/master? |
annashamray
approved these changes
Oct 31, 2024
|
ugh it still seems to be raising issues, I'll have to add https://github.com/open-formulieren/open-forms/blob/22d641bb16b4cab03b8ccdfb66efa332dc3b3a15/.github/workflows/trivy.yml#L11 probably as well to avoid this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/objects-api#463 partially