Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/11 producttype eigenschappen #41

Closed
wants to merge 7 commits into from
Closed

Feature/11 producttype eigenschappen #41

wants to merge 7 commits into from

Conversation

Floris272
Copy link
Contributor

@Floris272 Floris272 commented Feb 7, 2025 •
edited by stevenbal
Loading

Closes #11

Changes

  • Adds Eigenschap & ExterneCode models with fk to ProductType.
  • Both models are key value pairs and are created within the ProductType post request.
  • The same filter on the ProductTypeViewSet has been added to both models:
    • ?eigenschap=[key:value]
    • ?externe_code=[key:value]
    • The format is currently formatted using regex and i also added regex to the model fields, not sure if this is the best way.

@Floris272 Floris272 linked an issue Feb 7, 2025 that may be closed by this pull request
UPN + ‘externe productcode’ waarbij het laatste met key/value #13
Closed
@Floris272 Floris272 force-pushed the feature/11-producttype-eigenschappen branch 2 times, most recently from c6a3140 to 7666c77 Compare February 7, 2025 15:40
@Floris272 Floris272 force-pushed the feature/11-producttype-eigenschappen branch from 7666c77 to 359f12b Compare February 7, 2025 15:47
@Floris272 Floris272 marked this pull request as ready for review February 7, 2025 15:51
@Floris272 Floris272 linked an issue Feb 10, 2025 that may be closed by this pull request
Producttype eigenschappen : is analoog aan zaaktype eigenschappen #11
Open
@Floris272 Floris272 requested a review from stevenbal February 11, 2025 13:44
stevenbal
stevenbal requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Floris272 could you rebase on master?

Also please mention the issue number in the commit messages, this makes it easier to see why certain changes were made when checking the git logs.

I'm going to hold off on reviewing the rest of this PR until Alex answered #11 (comment), because that impacts the implementation

src/open_producten/producttypen/admin/externe_code.py
from open_producten.producttypen.models import ExterneCode


class ExterneCodeInline(admin.TabularInline):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this mentioned in #11, is this for #13?

In general I'd prefer to have separate PRs for separate issues, I'll allow it in this case since the features are implemented the same way

@Floris272 Floris272 closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Floris272 @stevenbal