New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add django-setup-configuration as optional dependency to configure Services #100

Closed

stevenbal opened this issue Nov 12, 2024 · 0 comments · Fixed by #99

Assignees

Labels

Contributor

stevenbal commented Nov 12, 2024

There must be a ConfigurationStep that allows configuring Services from a .YAML file. This is implemented in zgw-consumers itself to ensure that the format of this configuration file does not deviate for different projects and any changes to the format are included in a new zgw-consumers version

The text was updated successfully, but these errors were encountered:

stevenbal self-assigned this

stevenbal added the enhancement label

stevenbal mentioned this issue

✨ [#100] Add ConfigurationStep for Service model #99

Merged

stevenbal added a commit that referenced this issue


          ➕ [#100] Add django-setup-configuration dependency

eb4d0a7

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

bac3701

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

05db10e

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

e57ec00

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

6a730fa

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

62cb25c

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

9bc6626

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

cb7f854

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

10022c7

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

df06880

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

59ddd71

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

4fff053

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

27bb7b9

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

c440a96

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

286fcbe

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

c3ff18e

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

c93f74b

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

ead8ed0

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

9a0939f

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

be4021e

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

e39ed00

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

e9b6c35

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

53c11bb

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

1b168a6

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

43d38f5

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

f3203d6

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

c469abc

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

2c012a0

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

e749ac4

and add a test for idempotency

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

e9365ee

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

b18a012

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

eaa99af

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

79b917c

and add a test for idempotency

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

80e32f3

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

4f49947

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

edf1fa4

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

2c7f246

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

8ee076e

and add a test for idempotency

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

9148ba2

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

a98c6db

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

f1278be

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

8cee18f

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

bcfa9f2

and add a test for idempotency

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

531de75

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

d260acb

and add a test for idempotency

stevenbal added a commit that referenced this issue


          ➕ [#100] Add optional django-setup-configuration dependency

6b89e06

stevenbal added a commit that referenced this issue


          ✨ [#100] Add ConfigurationStep for Service model

130b0d4

which can load any number of Services, configured in a YAML file

stevenbal added a commit that referenced this issue


          ✅ [#100] Add tests for ServiceConfigurationStep

bf03b04

stevenbal added a commit that referenced this issue


          ♻️ [#100] Change several implementation details after discussion

a707cd7

* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`)
* use `identifier` instead of `slug` in config files
* add `setup_config_` prefix to test files
* remove `is_configured` and `validate_result`

stevenbal added a commit that referenced this issue


          ✅ [#100] Tests with required service fields and all service fields

2e4516a

and add a test for idempotency

stevenbal closed this as completed in #99

stevenbal added a commit that referenced this issue


          Merge pull request #99 from maykinmedia/feature/django-setup-configur…

ecfa9b2

…ation

✨ [#100] Add ConfigurationStep for Service model

stevenbal added a commit that referenced this issue


          📝 [#100] Documentation for ServiceConfigurationStep

3bd44dc

stevenbal added a commit that referenced this issue


          📝 [#100] Documentation for ServiceConfigurationStep

003ffd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment