Skip to content

Commit 9e4298f

Browse files
committed
πŸ“š Design: explain priorities and bump dependency one
Sometimes there might be multiple types to choose from. At the moment I'm not sure if it's best to stick with one type specifier or specify multiple (e.g. new feature that needs a dependency: βœ¨πŸ“¦). I want to be able to identify commits that change dependencies easily, but splitting them up makes the commit confusing, and using only πŸ“¦ is a bit strange for a commit that adds a new feature.
1 parent 0ca76b5 commit 9e4298f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

β€Ždocs/design.mdβ€Ž

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,17 @@ Some advantages:
143143
Although we are in favor of using emojis in the subject line, we do **not** allow emojis in the body.
144144
This makes it easier to `grep` for commit types.
145145

146+
The list in the table below is in order of priority, e.g. a backwards-incompatible change might improve an existing feature by breaking its API, but should _not_ be typed as an improvement (πŸ‘Œ).
147+
Similarly, if a dependency is changed, it's convenient to quickly spot this, e.g. when updating a conda feedstock.
148+
146149
| Emoji | Meaning | Similar to [Angular type](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines) | In changelog summary? |
147150
| ----- | ---------------------------------------------------------------- | ----------------------------------------- | ------------------------- |
148151
| πŸ’₯ | introduce a backward-incompatible (breaking) change / remove deprecated code | `\<type>!` (use `!` + `BREAKING CHANGE:`) | **Yes** |
152+
| πŸ“¦ | add, update or change a dependency | `build` | **Yes** |
149153
| ✨ | introduce new features | `feat` | **Yes** |
150154
| πŸ‘Œ | improve an existing code/feature (no breaking) | `perf`/`feat` | **Yes** |
151155
| πŸ› | fix a code bug | `fix` | **Yes** |
152156
| ❌ | mark code as deprecated (note removal version/replacement) | `refactor` | **Yes** |
153-
| πŸ“¦ | update or change a dependency | `build` | **Yes** |
154157
| πŸ“š | add or adapt documentation | `docs` | No |
155158
| πŸ”„ | refactor existing code with no behavior change | `refactor` | No |
156159
| πŸ§ͺ | add or adapt tests | `test` | No |

0 commit comments

Comments
Β (0)