Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native wayland support #7

Open
mpuric opened this issue Dec 14, 2021 · 1 comment
Open

Native wayland support #7

mpuric opened this issue Dec 14, 2021 · 1 comment

Comments

@mpuric
Copy link

mpuric commented Dec 14, 2021 •
edited
Loading

Thank you for this project, it's incredibly useful and the client performs rather well.

Everything works great with xwayland, but as soon as SDL_VIDEODRIVER=wayland is set I don't seem to get any rendered output even though the connection is established and no errors are being returned:

Initialize SDL
Initialize TTF
Initialize Parsec
Disable audio streaming
Connect to Parsec service
Connect to Parsec host
Initialize Video Decoder
Use resolution 1920x1080

wayland log
waydebug.log

It's not clear to me if native wayland is supported or not - no errors suggests that it might be, but no rendered window could suggest issues with my setup or something larger.

I'm using sway as my wm, so not sure if tiling could be causing some issues but I don't see how - any input would be much appreciated
mbroemme added a commit that referenced this issue Feb 22, 2022
@mbroemme
Added support for SDL_SetWindowKeyboardGrab():
2a3a0b3 
- With SDL_SetWindowKeyboardGrab() function, we are able to replace
  low level XGrabKeyboard() and XUngrabKeyboard() making the code
  much more portable. Also it fixes a couple of corner cases where
  window focus was lost when concurrent X applications tried to grab
  the keyboard.

- Client no longer depends on libx11 directly and with a future
  commit we can work on Wayland support as mentioned in #7.

- Requires SDL >= 2.0.16.
mbroemme added a commit that referenced this issue Feb 22, 2022
@mbroemme
Added support for SDL_SetWindowKeyboardGrab():
fe0b022 
- With SDL_SetWindowKeyboardGrab() function, we are able to replace
  low level XGrabKeyboard() and XUngrabKeyboard() making the code
  much more portable. Also it fixes a couple of corner cases where
  window focus was lost when concurrent X applications tried to grab
  the keyboard.

- Client no longer depends on libx11 directly and with a future
  commit we can work on Wayland support as mentioned in #7.

- Requires SDL >= 2.0.16.
@mbroemme
Copy link
Owner

@mpuric Could you give the version from branch https://github.com/mbroemme/vdi-stream-client/tree/2022_fixes_next_version a try? I didn't changed anything Wayland specific but require SDL >= 2.0.16 which greatly improved Wayland support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbroemme @mpuric