New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements and typo #17

Open

miketerada opened this issue Dec 1, 2021 · 0 comments

miketerada commented Dec 1, 2021 •

edited

Loading

There are a few values that can be added for completeness.

SegmentTemplate - can be part of AdaptationSet and should be added to the struct.

    <AdaptationSet mimeType="video/mp4" segmentAlignment="true" startWithSAP="1" bitstreamSwitching="false" subsegmentAlignment="true" subsegmentStartsWithSAP="1">
      <SegmentTemplate timescale="90000" duration="180180" startNumber="1"/>

Duration - should be added to SegmentTemplate.

Duration. *string `xml:"duration,attr"`

<SegmentTemplate timescale="44100" media="aac_$Number%09d$.mp4" initialization="aacinit.mp4" duration="88288" startNumber="1"/>

AudioChannelConfiguration - should be added to Representation.

AudioChannelConfiguration *AudioChannelConfiguration `xml:"AudioChannelConfiguration,omitempty"`

type AudioChannelConfiguration struct {
    SchemeIDURI *string `xml:"schemeIdUri,attr"`
    Value       *string `xml:"value,attr,omitempty"`
}

<Representation id="6" bandwidth="192000" audioSamplingRate="48000" codecs="ec-3">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:mpegB:cicp:ChannelConfiguration" value="6"/>
</Representation>

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment