-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: populate context from config #452
base: main
Are you sure you want to change the base?
Conversation
BPR02
commented
Nov 25, 2024
- fix ctx.data and ctx.assets are not populated by the config #451
- populate ctx.data and ctx.assets with the following info from the config:
- name
- description
- pack_format
- supported_formats
- populate ctx.data and ctx.assets with the following info from the config: - name - description - pack_format - supported_formats
@misode @RitikShah @edayot I think this PR can be merged. I tested it with my Observer plugin and it seems to be working as expected. I'd like a review if you guys have time. I added some tests, but there might be a more elegant way to test the output... I'm not super familiar with pytest, but I couldn't find anything online about passing an output to an object for pytest to catch, so I just put the text into a meta field and checked it afterwards. |
@BPR02 I have made a small adjustment: I've moved this copying logic to the Since the order is currently (1) Further remarks
|
I've made some more drastic changes now, and it's not quite done yet, because there is some behavior change, for example when pack metadata is present both in the beet config and in
With regards to which config takes priority, I am unsure whether we should keep compatibility with the released beet version, or decide from scratch what the ideal behavior should be. |
I think it makes sense to make the beet config be the "one true source" of configuration values. I'm not sure what the current release behavior is, but for this PR maybe it should be changed to only pull the |