minor rework (lint,..)

add license & go report badge

Author: mch1307

Diff for: LICENSE.md

@@ -0,0 +1,7 @@
+The MIT License (MIT)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Diff for: README.md

@@ -2,6 +2,8 @@
 
 [![Travis branch](https://img.shields.io/travis/mch1307/gomotics/master.svg)](https://travis-ci.org/mch1307/gomotics)
 [![Coverage Status](https://coveralls.io/repos/github/mch1307/gomotics/badge.svg?branch=master)](https://coveralls.io/github/mch1307/gomotics?branch=master)
+[![Go Report Card](https://goreportcard.com/badge/mch1307/gomotics)](http://goreportcard.com/report/mch1307/gomotics)
+[![license](https://img.shields.io/github/license/mch1307/gomotics.svg)](https://github.com/mch1307/gomotics/blob/master/LICENSE.md)
 
 Work In Progress
 

Diff for: nhc/nhc_test.go

@@ -28,7 +28,7 @@ var (
 	`
 	testConf = config.NhcConf{Host: "localhost", Port: 8000}
 	command  = Event{ID: 1, Value: 100}
-	myCmd    NhcSimpleCmd
+	myCmd    SimpleCmd
 )
 
 type Sessions []*Session

Diff for: nhc/router.go

@@ -18,7 +18,6 @@ func SaveItem(item MessageIntf) {
 }
 
 // Route parse and route incoming message the right handler
-// ugly, code repetition with json parsing?
 func Route(msg Message) {
 	if msg.Cmd == "listlocations" {
 		if err := json.Unmarshal(msg.Data, &nhcLocations); err != nil {

Diff for: nhc/types.go

@@ -3,10 +3,15 @@ package nhc
 import "encoding/json"
 
 const (
-	RegisterCMD     = "{\"cmd\":\"startevents\"}"
-	ListActions     = "{\"cmd\":\"listactions\"}"
-	ListLocations   = "{\"cmd\":\"listlocations\"}"
-	ListEnergies    = "{\"cmd\":\"listenergy\"}"
+	// RegisterCMD holds NHC startevents
+	RegisterCMD = "{\"cmd\":\"startevents\"}"
+	// ListActions holds NHC listactions
+	ListActions = "{\"cmd\":\"listactions\"}"
+	// ListLocations holds NHC listlocations
+	ListLocations = "{\"cmd\":\"listlocations\"}"
+	// ListEnergies holds NHC listenergy
+	ListEnergies = "{\"cmd\":\"listenergy\"}"
+	// ListThermostats holds NHC listthermostat
 	ListThermostats = "{\"cmd\":\"listthermostat\"}"
 )
 
@@ -22,22 +27,22 @@ type GenericItem struct {
 }
 
 // Message generic struct to hold nhc messages
-// used to identify the message type before futher parsing
+// used to identify the message type before further parsing
 type Message struct {
 	Cmd   string `json:"cmd"`
 	Event string `json:"event"`
 	Data  json.RawMessage
 }
 
-// NhcSimpleCmd type holding a nhc command
-type NhcSimpleCmd struct {
+// SimpleCmd type holding a nhc command
+type SimpleCmd struct {
 	Cmd   string `json:"cmd"`
 	ID    int    `json:"id"`
 	Value int    `json:"value1"`
 }
 
 // Stringify return the string version of SimpleCmd
-func (sc NhcSimpleCmd) Stringify() string {
+func (sc SimpleCmd) Stringify() string {
 	tmp, _ := json.Marshal(sc)
 	return string(tmp)
 }

Diff for: server/server.go

@@ -82,7 +82,7 @@ func nhcCmd(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		fmt.Println("invalid request: value should be numeric")
 	}
-	var myCmd nhc.NhcSimpleCmd
+	var myCmd nhc.SimpleCmd
 	myCmd.Cmd = "executeactions"
 	myCmd.ID = id
 	myCmd.Value = val