Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedArrayBuffer warning in Chrome #102

Open
nheapsspreadco opened this issue Apr 22, 2021 · 3 comments
Open

SharedArrayBuffer warning in Chrome #102

nheapsspreadco opened this issue Apr 22, 2021 · 3 comments

Comments

@nheapsspreadco
Copy link

Hi!

Recently upgraded to version 5.3.2 and now getting the following warning in Chrome:

image

It seems that in msgpack5.js there is code that checks for SharedArrayBuffer, but it doesn't actually use it as part of the functionality.

Chrome version 91 (yet to be released) will apparently require a web page to be cross-origin isolated, requiring the use of new response headers, etc. Only sites modified as such will be able to use SharedArrayBuffer.

I have tried our site in Chrome DEV version 91, and all appears fine - in fact, it seems that the msgpack library no longer makes any checks on SharedArrayBuffer in this context.

May I please ask if there is an intention to use SharedArrayBuffer in earnest in the future, or will the msgpack5 library always gracefully "degrade"?

Many thanks,

Nick

@mcollina
Copy link
Owner

I don't have a clue why we are using it for that, so I'm up for removing if you'd like to send a PR?

@Donov4n
Copy link

Donov4n commented Jun 22, 2021

Any news on this ?

@mcollina
Copy link
Owner

Any news on this ?

Would you like to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants