Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in the encoder.js #42

Open
sashee opened this issue Jan 19, 2016 · 1 comment
Open

Fix in the encoder.js #42

sashee opened this issue Jan 19, 2016 · 1 comment

Comments

@sashee
Copy link

sashee commented Jan 19, 2016

Hi,

we needed an amendment to the encoder.js to make it work in our codebase. You can find it at: sashee@35cb7a6 .

We are unsure whether it is a bug in the library or in the remote server we are using. Feel free to use it and/or incorporate it in your codebase if you see fit. Please close this issue if this change is deemed unnecessary.

Note: I am not the author of the patch, so I can provide little help what exactly it does. I ran the tests and it did not break any.

@mcollina
Copy link
Owner

Would you like to send a PR adding a test for it?

I'm not sure why that is needed in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants