Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Horizontal scrollbar obscures content #1250

Closed
wants to merge 1 commit into from

Conversation

patiboh
Copy link

@patiboh patiboh commented Apr 23, 2023

Fixes #1249

Added padding-block to allow space for scrollbar.

Firefox

Screenshot 2023-04-23 at 11 55 03

Chrome

Screenshot 2023-04-23 at 11 54 38

Safari

Screenshot 2023-04-23 at 11 55 03

@patiboh patiboh changed the title fix: Horizontal scrollbar obscures content #1249 fix: Horizontal scrollbar obscures content Apr 23, 2023
@yarusome
Copy link
Contributor

yarusome commented May 3, 2023

This fix makes the items in live examples take unnecessarily large space on Windows, though:

screenshot

The core issue here is that MacOS uses overlay scrollbars whereas Windows uses classic ones. CSS Overflow Module Level 4 actually proposes to add the always value to scrollbar-gutter to solve the very problem this PR tries to fix, but Apple itself, as mentioned in the spec, is reluctant to add this value.

@patiboh
Copy link
Author

patiboh commented May 4, 2023

I see, thank you for your feedback and the link to the spec as well as the explanation about the unfortunate Apple exception.
I would tend to think that extra space around scrolled content is preferable than not seeing the content as you scroll - the latter makes it difficult to take in what is written inside the examples. But I'll close this PR if this solution is not acceptable or you prefer to wait for a conclusion on the spec that Apple adheres to

@patiboh
Copy link
Author

patiboh commented May 5, 2023

Solved this issue locally by changing the system settings for scrollbars:
Screenshot 2023-05-05 at 09 06 30

@patiboh patiboh closed this May 5, 2023
@patiboh patiboh deleted the add-padding-for-scrollbar branch May 5, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scrollbar obscures content
2 participants