Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glaring white in dark mode #37197

Open
MickMQ opened this issue Dec 13, 2024 · 6 comments
Open

Glaring white in dark mode #37197

MickMQ opened this issue Dec 13, 2024 · 6 comments
Labels
Content:Learn:Django Learning area Django docs needs decision The task needs consensus through discussion

Comments

@MickMQ
Copy link

MickMQ commented Dec 13, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Admin_site

What specific section or headline is this issue about?

The screenshots

What information was incorrect, unhelpful, or incomplete?

Nothing incorrect but I am using dark mode and suddenly I am dazzled by a screen print. My opinion is that all documents/ pages should be in dark mode by default with options to change. Some people may have difficulty reading dark mode but it won't cause hurt if light mode is just a click away. This issue is (almost) as harmful as drivers dazzled by headlights.

What did you expect to see?

Dark mode as default

Do you have any supporting links, references, or citations?

Not applicable

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@MickMQ MickMQ added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 13, 2024
@github-actions github-actions bot added Content:Learn:Django Learning area Django docs and removed Content:Learn:Django Learning area Django docs labels Dec 13, 2024
@hamishwillee
Copy link
Collaborator

Thanks for your report.

  1. Neither Django or MDN had dark mode when that tutorial was created.
  2. MDN does not have a policy on light or dark mode images "by default if possible".

That said, there is no reason not to change these. Would you like to create a PR with the changed images?

@MickMQ
Copy link
Author

MickMQ commented Dec 13, 2024 via email

@hamishwillee
Copy link
Collaborator

Would you like to create a PR with the changed images?

Sorry, I do not understand the last sentence.

Presumably you are doing the tutorial. I am asking if you would like to fix this yourself by regenerating the images in dark mode and creating a pull request for review.

@MickMQ
Copy link
Author

MickMQ commented Dec 13, 2024 via email

@Josh-Cena Josh-Cena added Content:Learn:Django Learning area Django docs needs decision The task needs consensus through discussion and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 13, 2024
@hamishwillee
Copy link
Collaborator

Awesome! If I had to do this (and I will eventually if you don't get around to it), I would start from the "worked project": https://github.com/mdn/django-locallibrary-tutorial?tab=readme-ov-file#quick-start

That link takes you to the instructions how to run the finished project. I'd create a bunch of books as show in the existing screenshots. Then I'd take my own screenshots in dark mode (which you should get in Django because your computer/browser will be set to dark mode).

Then you replace the original images in the github source tree for this repository with your images, using the same name. This would be done on a local computer.

The workflow for using the toolchain "yari" is described here: https://github.com/mdn/content/blob/main/CONTRIBUTING.md

I appreciate this is a bit of a learning curve, but have a look and see what you think.

@MickMQ
Copy link
Author

MickMQ commented Dec 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Django Learning area Django docs needs decision The task needs consensus through discussion
Projects
None yet
Development

No branches or pull requests

3 participants