-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glaring white in dark mode #37197
Comments
Thanks for your report.
That said, there is no reason not to change these. Would you like to create a PR with the changed images? |
Sorry, I do not understand the last sentence.
I
…On Fri, 13 Dec 2024, 02:11 Hamish Willee, ***@***.***> wrote:
Thanks for your report.
1. Neither Django or MDN had dark mode when that tutorial was created.
2. MDN does not have a policy on light or dark mode images "by default
if possible".
That said, there is no reason not to change these. Would you like to
create a PR with the changed images?
—
Reply to this email directly, view it on GitHub
<#37197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHU6Z2IF5MWR3CGKC2QKIPT2FI667AVCNFSM6AAAAABTRA3K7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGM4DCNJVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Presumably you are doing the tutorial. I am asking if you would like to fix this yourself by regenerating the images in dark mode and creating a pull request for review. |
Hamish,
Yes I am willing to have a go but I have very little web/html experience.
Mick
…On Fri, 13 Dec 2024, 04:27 Hamish Willee, ***@***.***> wrote:
Would you like to create a PR with the changed images?
Sorry, I do not understand the last sentence.
Presumably you are doing the tutorial. I am asking if you would like to
fix this yourself by regenerating the images in dark mode and creating a
pull request for review.
—
Reply to this email directly, view it on GitHub
<#37197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHU6Z2KE5GJGMVXFGW4M3XT2FJO3VAVCNFSM6AAAAABTRA3K7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGUZDKMRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Awesome! If I had to do this (and I will eventually if you don't get around to it), I would start from the "worked project": https://github.com/mdn/django-locallibrary-tutorial?tab=readme-ov-file#quick-start That link takes you to the instructions how to run the finished project. I'd create a bunch of books as show in the existing screenshots. Then I'd take my own screenshots in dark mode (which you should get in Django because your computer/browser will be set to dark mode). Then you replace the original images in the github source tree for this repository with your images, using the same name. This would be done on a local computer. The workflow for using the toolchain "yari" is described here: https://github.com/mdn/content/blob/main/CONTRIBUTING.md I appreciate this is a bit of a learning curve, but have a look and see what you think. |
Hamish,
All that learning to be a MDN contributor seems a step too far for me just
now.
The attached zip file contains the little I have done so far - as a sample.
I have found the 'offending' images - glaring white in dark mode - and
offer replacements that are not.
The zip file contains an xl spreadsheet of image names and their mdn urls,
plus the images as png files.
Let me know if this is useful to you and I will continue with it. I can
change the image type if png is not acceptable.
Cheers
Mick
…On Fri, 13 Dec 2024 at 05:51, Hamish Willee ***@***.***> wrote:
Awesome! If I had to do this (and I will eventually if you don't get
around to it), I would start from the "worked project":
https://github.com/mdn/django-locallibrary-tutorial?tab=readme-ov-file#quick-start
That link takes you to the instructions how to run the finished project.
I'd create a bunch of books as show in the existing screenshots. Then I'd
take my own screenshots in dark mode (which you should get in Django
because your computer/browser will be set to dark mode).
Then you replace the original images in the github source tree for this
repository with your images, using the same name. This would be done on a
local computer.
The workflow for using the toolchain "yari" is described here:
https://github.com/mdn/content/blob/main/CONTRIBUTING.md
I appreciate this is a bit of a learning curve, but have a look and see
what you think.
—
Reply to this email directly, view it on GitHub
<#37197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHU6Z2P6GOLJMKT3OKTIHRD2FJYWNAVCNFSM6AAAAABTRA3K7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGYYDKOBTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
MDN URL
https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Admin_site
What specific section or headline is this issue about?
The screenshots
What information was incorrect, unhelpful, or incomplete?
Nothing incorrect but I am using dark mode and suddenly I am dazzled by a screen print. My opinion is that all documents/ pages should be in dark mode by default with options to change. Some people may have difficulty reading dark mode but it won't cause hurt if light mode is just a click away. This issue is (almost) as harmful as drivers dazzled by headlights.
What did you expect to see?
Dark mode as default
Do you have any supporting links, references, or citations?
Not applicable
Do you have anything more you want to share?
No response
MDN metadata
Page report details
en-us/learn/server-side/django/admin_site
The text was updated successfully, but these errors were encountered: