Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matchMedia or (window.client.height) to dictate some features #120

Closed
Tracked by #5216
peterbe opened this issue Sep 17, 2019 · 3 comments
Closed
Tracked by #5216

Use matchMedia or (window.client.height) to dictate some features #120

peterbe opened this issue Sep 17, 2019 · 3 comments
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle p4 Not urgent, only if time allows

Comments

@peterbe
Copy link
Contributor

peterbe commented Sep 17, 2019

Here and here and here the search widget uses isMobileUserAgent() to determine how the functionality should differ. For example, if you're on a mobile device you're more likely to want to see fewer search results because your screen is smaller.

The whole idea of "tailoring" the rendering based on the browser is good but we shouldn't do this based on the type of browser but instead of features that actually relate. For example, if your browser window isn't very high, it should only display, say, 5 search results so that scrolling doesn't suck. But if you're on a big screen, it might help to show a lot more. So this logic depends on the client inner height. So probably better to use something like window.matchMedia to figure these things out.

@peterbe
Copy link
Contributor Author

peterbe commented Sep 17, 2019

Here as well where it makes sure the top of the search input is at the top of the screen if the screen real estate is small so that the pop-up keyboard doesn't hide the search results too much.

By the way, it might be an attractive option to make the whole search widget, on small screens, something that takes up 100% of the whole screen instead of tricks to scroll things into position.

@peterbe peterbe added the good first issue A good issue for newcomers to get started with. label Sep 17, 2019
@tobinmori tobinmori added p3 We don't have visibility when this will be addressed. p4 Not urgent, only if time allows and removed good first issue A good issue for newcomers to get started with. p3 We don't have visibility when this will be addressed. labels Jul 21, 2020
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Nov 25, 2021
@schalkneethling
Copy link

@fiji-flo Do you know whether this was addressed as part of the redesign?

@github-actions github-actions bot removed the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Feb 16, 2022
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Mar 25, 2022
Repository owner moved this from Backlog to Done in Yari Platform Engineering May 27, 2022
@github-actions github-actions bot added the idle label Dec 21, 2022
@caugner
Copy link
Contributor

caugner commented Jun 24, 2024

Closing in favor of the newer #5650.

@caugner caugner closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle p4 Not urgent, only if time allows
Projects
Development

No branches or pull requests

4 participants