You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here and here and here the search widget uses isMobileUserAgent() to determine how the functionality should differ. For example, if you're on a mobile device you're more likely to want to see fewer search results because your screen is smaller.
The whole idea of "tailoring" the rendering based on the browser is good but we shouldn't do this based on the type of browser but instead of features that actually relate. For example, if your browser window isn't very high, it should only display, say, 5 search results so that scrolling doesn't suck. But if you're on a big screen, it might help to show a lot more. So this logic depends on the client inner height. So probably better to use something like window.matchMedia to figure these things out.
The text was updated successfully, but these errors were encountered:
Here as well where it makes sure the top of the search input is at the top of the screen if the screen real estate is small so that the pop-up keyboard doesn't hide the search results too much.
By the way, it might be an attractive option to make the whole search widget, on small screens, something that takes up 100% of the whole screen instead of tricks to scroll things into position.
tobinmori
added
p3
We don't have visibility when this will be addressed.
p4
Not urgent, only if time allows
and removed
good first issue
A good issue for newcomers to get started with.
p3
We don't have visibility when this will be addressed.
labels
Jul 21, 2020
Here and here and here the search widget uses
isMobileUserAgent()
to determine how the functionality should differ. For example, if you're on a mobile device you're more likely to want to see fewer search results because your screen is smaller.The whole idea of "tailoring" the rendering based on the browser is good but we shouldn't do this based on the type of browser but instead of features that actually relate. For example, if your browser window isn't very high, it should only display, say, 5 search results so that scrolling doesn't suck. But if you're on a big screen, it might help to show a lot more. So this logic depends on the client inner height. So probably better to use something like
window.matchMedia
to figure these things out.The text was updated successfully, but these errors were encountered: