Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other websites from the StackExchange network to the StackExchange implementation #110

Open
mdolr opened this issue Oct 10, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 10, 2020

Currently the StackExchange implementation only works for stackoverflow.com, it should work with any website that supports the stackexchange API.

To do this you should modify the dispatcher function in js/core.js and change the implementation in js/templates/stackexchange.js

@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 10, 2020
@dgnaegi
Copy link

dgnaegi commented Oct 10, 2020

hi, i would like to do this one tomorrow :)

Can you assign me to this issue?

@dgnaegi
Copy link

dgnaegi commented Oct 11, 2020

Hi @mdolr thanks for assigning me and the well documented first issue :)

I opened a PR regarding this Issue: #114

Because the Stackexchange-API requires a site (e.g. physics) i replaced the getDomain() method with a getSite() method. I would appreciate a review.

grafik

@mdolr
Copy link
Owner Author

mdolr commented Oct 11, 2020

Ok I might have not been clear enough in the issue, I was expecting you to find a way to include every site from the stackexchange network which means everything listed here as the stackexchange network operates on multiple domains. There might be an API call that we could fire when the extension starts to get every domain from the stackexchange network and then use that.

It seems we can get a list of stackexchange websites using GET /sites. This would have to be done at the start of the extension in the background script I guess

@mdolr
Copy link
Owner Author

mdolr commented Oct 11, 2020

This is already ok-ish as most of the domains are [something].stackexchange.com and I'll merge this if it's not possible to include everything, but it would save us some time in the future if they open a new website like superuser.com for example, we wouldn't have to add it manually.

@dgnaegi
Copy link

dgnaegi commented Oct 11, 2020

Ok, thanks for further explaination. I'll try to find an universal solution during the next 2-3 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants