Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The survol container should display a placeholder / loading icon #112

Open
mdolr opened this issue Oct 11, 2020 · 6 comments
Open

The survol container should display a placeholder / loading icon #112

mdolr opened this issue Oct 11, 2020 · 6 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 11, 2020

While a survolBackgroundRequest is being done, the container should display a loading icon or even better something like this.

@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 11, 2020
@carlosfrontend
Copy link

I am interested in working on this

@mdolr
Copy link
Owner Author

mdolr commented Oct 11, 2020

Feel free to 👍

@carlosfrontend
Copy link

Thanks i will try 👍

@carlosfrontend
Copy link

carlosfrontend commented Oct 12, 2020

I saw this
But is very dificult for me 😞

@mdolr
Copy link
Owner Author

mdolr commented Oct 12, 2020

Well we are not using vue, afaik it should be possible to make a skeleton in pure css.

let’s start by adding a loading icon and we’ll replace by a skeleton later

@ask-imran
Copy link
Contributor

ask-imran commented Oct 16, 2020

Hey @carlosfrontend
Let me know if you are working on this, I would love to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants