Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The survol container is removed from the DOM in SPA #122

Open
mdolr opened this issue Oct 13, 2020 · 0 comments
Open

The survol container is removed from the DOM in SPA #122

mdolr opened this issue Oct 13, 2020 · 0 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 13, 2020

When changing page in Single Page Applications, sometimes the survol container is removed from the DOM. This is the case on osu's website for example. It should be re-inserted if it has been removed. Also we should make sure that the old event listeners are removed to avoid memory leaks.
@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdolr