Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom templates for websites supporting oEmbed #140

Open
mdolr opened this issue Oct 18, 2020 · 0 comments
Open

Add custom templates for websites supporting oEmbed #140

mdolr opened this issue Oct 18, 2020 · 0 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 18, 2020

We've used oEmbed for many websites already (twitter, reddit, youtube, ...). But there are still many sites that would benefit from getting custom oEmbed support instead of using meta-data parsing ( js/templates/base.js ). This issue will keep track of every service added to the extension.

How to proceed :

  • If you're not familiar with the extension read CONTRIBUTING.MD
  • Find a service you want to add support for by using this list of websites having an oEmbed API.
  • Create a custom template in js/templates/{serviceName}.js
  • If needed add a custom CSS sheet in css/templates/{serviceName}.css please try to re-use already existing CSS as much as possible.
  • Add your script and CSS sheet to the manifest.json file
  • Inject content into the container properly = every element you want to inject into the DOM should be created and inserted using JS, textNodes should be used to contain the data.
  • Once done, submit a PR, reference Add custom templates for websites supporting oEmbed #140 in the body or title so the PR shows up in the conversation below

Ask questions if you're not sure about something !! Also please do not ask if you can work on this, just in case yes you can!!

Don't inject HTML directly using {parentNode}.innerHTML = {raw html} for security reasons, by doing that you allow people to inject malicious scripts through the extension. PRs doing this won't be reviewed and will be closed automatically

@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 18, 2020
@mdolr mdolr pinned this issue Oct 18, 2020
Repository owner deleted a comment from sprakash57 Oct 18, 2020
Repository owner locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant