Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the changelog on onboarding page #141

Open
mdolr opened this issue Oct 18, 2020 · 2 comments · May be fixed by #156
Open

Cache the changelog on onboarding page #141

mdolr opened this issue Oct 18, 2020 · 2 comments · May be fixed by #156
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 18, 2020 •
edited
Loading

Currently every time you open the onboarding / settings page via the popup it requests the changelog using the Github API. The request is done js/utils/onBoardingbootstrap.js. The response should be cached as the extension likely won't update while its running.

(don't ask if you can work on this please 🙏, I wouldn't have created the issue otherwise)
@mdolr mdolr added good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed labels Oct 18, 2020
@ask-imran
Copy link
Contributor

Picking it up

@joelazwar joelazwar linked a pull request Nov 18, 2020 that will close this issue
Open
@joelazwar
Copy link
Contributor

hey @mdolr since I saw this wasn't fixed yet, made a quick PR for this issue, #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #141 - Caches changelog on the onboarding/settings page joelazwar/survol
3 participants
@mdolr @ask-imran @joelazwar