Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter integration : Embed medias #20

Open
mdolr opened this issue Oct 12, 2019 · 1 comment
Open

Twitter integration : Embed medias #20

mdolr opened this issue Oct 12, 2019 · 1 comment
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 12, 2019 •
edited
Loading

Currently twitter picutres/videos appear like that in tweets

Make it so that in twitter.js you parse html given by twitter in the response to embed the media
The result should look like this :
image
@mdolr mdolr added good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed labels Oct 12, 2019
sravan7 added a commit to sravan7/survol that referenced this issue Oct 12, 2019
@sravan7
Twitter integration : Embed medias mdolr#20
4c3518a
@sravan7 sravan7 mentioned this issue Oct 12, 2019
Closed
@mdolr mdolr added priority Should be trated in priority enhancement New feature or request Future improvements Should be treated / discussed for future versions and removed good first issue Good for newcomers priority Should be trated in priority labels Oct 13, 2019
@mdolr
Copy link
Owner Author

mdolr commented Oct 14, 2019

pic.twitter.com does not seem like a way to embed medias easily, this will need another solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdolr