Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twitter profiles #37

Open
mdolr opened this issue Oct 4, 2020 · 5 comments
Open

Add twitter profiles #37

mdolr opened this issue Oct 4, 2020 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 4, 2020

Integrate twitter profiles to survol, should display profile picture + bio + ?
@jsilvaigor

@mdolr mdolr added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest labels Oct 4, 2020
@jsilvaigor
Copy link
Contributor

I'll take a look on this one.

@jsilvaigor
Copy link
Contributor

I was able to get the profile picture and add it to the extension (PR #38). To get the profile description we have to call the twitter api or create some mechanism to get the profile page and render it on a virtual dom, because it's client side rendered with javascript.

@mdolr
Copy link
Owner Author

mdolr commented Oct 4, 2020

Ok, I've merged #38 for now thanks

@shikharsaxena98
Copy link

Is this closed? Or is there any work to be done here?

@mdolr
Copy link
Owner Author

mdolr commented Oct 10, 2020

Hum this is not closed, #38 added twitter profile picture to tweets which is nice but it didn't integrate twitter profile pages. If you want to do it you can there is work to be done indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants