Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandcamp #52

Open
mdolr opened this issue Oct 4, 2020 · 7 comments
Open

Add bandcamp #52

mdolr opened this issue Oct 4, 2020 · 7 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 4, 2020

Like #51 add bandcamp song title / author

@mdolr mdolr added enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed labels Oct 4, 2020
@tomwalsh-home
Copy link

I'd like a go at this please 👍

@mdolr
Copy link
Owner Author

mdolr commented Oct 10, 2020

Hello, have you been able to work on this @tomwalsh-home or is the issue available for someone to work on ?

@tomwalsh-home
Copy link

Hello, have you been able to work on this @tomwalsh-home or is the issue available for someone to work on ?

Hi @mdolr, no i havent, and i probably wont get chance :(

@joelazwar
Copy link
Contributor

Hi @mdolr I would like to try and add this feature :)

@mdolr
Copy link
Owner Author

mdolr commented Oct 16, 2020

Feel free to

@joelazwar
Copy link
Contributor

Hey @mdolr It seems like the base template already shows the info you mentioned (title/author) But I thought I would try and make a dedicated template.js file similar to the soundcloud feature you suggested but I'm having trouble finding an oembed/api to request bandcamp info from. Do you happen to have any ideas?

@mdolr
Copy link
Owner Author

mdolr commented Oct 18, 2020

Honestly I dont' know if they have an API or anything, I'm pretty sure it's possible to embed tracks, I guess you could wait for #111, and then embed the track in a preview once it becomes possible to interact with the container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants