Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become maintainer/put out new release? #28

Open
JoeMurray opened this issue Nov 16, 2020 · 8 comments
Open

Become maintainer/put out new release? #28

JoeMurray opened this issue Nov 16, 2020 · 8 comments

Comments

@JoeMurray
Copy link
Contributor

@sabrinaleroy @bastienho you two seem to be maintaining this plugin. I'd encourage you to become the maintainer and maybe put out a new release. Thanks for sharing!

@ralphyke
Copy link

It's a really great plugin. I've found what looks like a bug:

When using the lineitem editor extension in Civi, when changing the Financial Type on a record, it sort of hangs (gives the little whirly thing) but the update is done, as pressing escape and then refreshing shows the update. However, after talking to JMA Consulting who support that extension, they have pointed out that the line-item is not linked with the financial item, and that maybe there is an incorrect adjustment made during recording the payments via WooCommerce.

@ralphyke
Copy link

Would also be good if it was enhance to be able to create memberships in Civi but that's probably more complicated and would have to use the WooCommerce members plugin which is paid for, although there could be ways around that. I noticed that there is perhaps something built in but not yet released because if there is not a _civicrm_membership meta_key entry for 0 in the wp_postmeta table, it tries to create a membership but fails with a foreign key constraint (I don't know how this happened so I had to insert a _civicrm_membership record for this to solve the problem). The only difference I could see with other purchases was that the person signing up put "member" as their title.

@JoeMurray
Copy link
Contributor Author

Heh @ralphyke ! Not sure if you noticed, but JMA will be fixing the first point above shortly #32 . On the second point, it might be useful to create a different issue or two.

@ralphyke
Copy link

Hi, thanks for the feedback but do you mean that JMA are going to make a change to WooCommerce CiviCRM WP Plugin or their extension because I think the problem is in the WooCommerce CiviCRM WP Plugin?

@JoeMurray
Copy link
Contributor Author

We're going to submit a fix here on this repo.

@ralphyke
Copy link

Brilliant, thanks

@bastienho
Copy link
Collaborator

Heh @ralphyke ! Not sure if you noticed, but JMA will be fixing the first point above shortly #32 . On the second point, it might be useful to create a different issue or two.

That's great, @sabrinaleroy and I were going to work on it.

We now have to merge all forks /branches for a stable version

@agileware-justin
Copy link

Might want to test #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants