Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a Node OIDC library #9736

Closed
mrjones-plip opened this issue Jan 10, 2025 · 4 comments
Closed

Choose a Node OIDC library #9736

mrjones-plip opened this issue Jan 10, 2025 · 4 comments
Labels
Type: Technical issue Improve something that users won't notice

Comments

@mrjones-plip
Copy link
Contributor

Describe the issue
For 9735 we need to have a native JS library we use so we're not re-inventing the wheel for a problem that is known to be well solved

Describe the improvement you'd like
research best in class existing solutions for have a JS app make OIDC calls. show candidates and reasons for selecting the final choice

Describe alternatives you've considered
DIY Not invented here 😢

@mrjones-plip mrjones-plip added the Type: Technical issue Improve something that users won't notice label Jan 10, 2025
@Kymoraa
Copy link

Kymoraa commented Jan 22, 2025

Hello @mrjones-plip and @jkuester
I have shared my findings on this doc: https://docs.google.com/document/d/1TP4U6guOC-uaNZ3IYlZ4Gdn5fHygjrWIabywo86nGGs/edit?usp=sharing
Let me know if I am on the right path.

@mrjones-plip
Copy link
Contributor Author

@Kymoraa - this looks great - thanks for sharing your current status of research.

it looks like you propose openid-client and cite some solid reasons. Sounds good!

@jkuester - thoughts on how to see this ticket through to be closed? I was thinking maybe a next step would be to do some proof of concept code to show how this library might be used? An extra bonus would be to stand up an instance of Keycloak and document making API calls against that?

@jkuester
Copy link
Contributor

Honestly, I think @Kymoraa's doc spells everything out very well. My vote is that we commit to moving forwards with openid-client and just close this issue! The openid-client seems to fit our needs with no obvious downsides, so I say we just move on to implementing the feature!

@mrjones-plip
Copy link
Contributor Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
None yet
Development

No branches or pull requests

3 participants