chore(#9768): uplift sinon to 19+ #9780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uplifted sinon to 19+ and modified the useFakeTimes function.
jkuester
changed the title
jkuester
requested changes
Feb 5, 2025
There was a problem hiding this comment.
@akshat16j Thanks for the PR! Looks like the linting is failing, but if you can get that fixed and the build passes we should be able to get this merged!
FYI, you can run the linting locally via the npm run lint command. 👍
|
Ok! will definitely do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplifted sinon to 19+ and modified the useFakeTimes function.
Closes #9768
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.